Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bitvector types into util/bitvector_types.h #5898

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

kroening
Copy link
Member

@kroening kroening commented Mar 8, 2021

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The rationale is that types of a particular group (say bitvectors or
pointers) are often used together with the expressions that are specific for
them.

The goal is that std_types.h will only contain the basic types, such as
bool_typet.
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #5898 (c09297c) into develop (81d075d) will increase coverage by 0.00%.
The diff coverage is 98.67%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5898   +/-   ##
========================================
  Coverage    73.09%   73.09%           
========================================
  Files         1428     1430    +2     
  Lines       155075   155076    +1     
========================================
+ Hits        113357   113358    +1     
  Misses       41718    41718           
Impacted Files Coverage Δ
...java_bytecode/java_bytecode_internal_additions.cpp 100.00% <ø> (ø)
jbmc/src/java_bytecode/remove_exceptions.cpp 95.58% <ø> (ø)
...rams/remove_virtual_functions_without_fallback.cpp 98.52% <ø> (ø)
...s/variable-sensitivity/abstract_pointer_object.cpp 76.66% <ø> (ø)
...ses/variable-sensitivity/abstract_value_object.cpp 95.43% <ø> (ø)
...s/variable-sensitivity/interval_abstract_value.cpp 81.96% <ø> (ø)
src/ansi-c/c_nondet_symbol_factory.cpp 100.00% <ø> (ø)
src/ansi-c/padding.cpp 93.36% <ø> (ø)
src/cpp/cpp_is_pod.cpp 100.00% <ø> (ø)
src/cpp/cpp_type2name.cpp 89.13% <ø> (ø)
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c64da...d30e826. Read the comment docs.

@kroening kroening merged commit 83ebd32 into develop Mar 10, 2021
@kroening kroening deleted the move_bitvector_types branch March 10, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants