Bump chrono to 0.4 #960
Merged
Bump chrono to 0.4 #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
force-pushed
the
chrono
branch
2 times, most recently
from
0e98414 to
5f548b4
Compare
|
Nice, saw the chrono 0.4 announcement earlier and thought we should bump the dep in diesel asap :) Should we enable chrono's serde feature when our serde feature is enabled? Can we? |
|
@killercup you mean conditionally depending on chrono's serde feature if Diesel's serde is enabled? I think that would be reasonable, reducing the "why isn't serde working" stumbling block. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow the usage of serde 1.0 with diesel again since chrono 0.3.1 has been
yanked.