implement jsonb_object (both variants) #4256
Conversation
| /// # } | ||
| /// ``` | ||
| #[sql_name = "jsonb_object"] | ||
| fn jsonb_object_with_keys_and_values<Arr: TextArrayOrNullableTextArray + MaybeNullableValue<Jsonb>>( |
There was a problem hiding this comment.
I think we need to use the `CombinedNullableValue trait that I've introduced in b488df4. The signature should be essentially the same as there.
| /// # Ok(()) | ||
| /// # } | ||
| /// ``` | ||
| fn jsonb_object<Arr: TextArrayOrNullableTextArray + MaybeNullableValue<Jsonb>>( |
There was a problem hiding this comment.
Can we add a test case for calling this function with a null value here? Something like jsonb_object::<Nullable<Array<Text>>, _>(None)?
valkrypton
force-pushed
the
feat/add/jsonb_object
branch
from
7ef7055
to
cdaec0c
Compare
| /// | ||
| /// let jsonb = diesel::select(jsonb_object::<Nullable<Array<Text>>, _>(None::<Vec<String>>)) | ||
| /// .get_result::<Option<Value>>(connection); | ||
| /// assert!(jsonb.is_err()); |
There was a problem hiding this comment.
That does seem to be not correct, this should return None and no error.
There was a problem hiding this comment.
If I replace the current statement with this:
let jsonb = diesel::select(jsonb_object::<Nullable<Array<Text>>, _>(None::<Vec<String>>))
.get_result::<Option<Value>>(connection)?;
The test fails because of this error:
called `Result::unwrap()` on an `Err` value: DatabaseError(Unknown, "current transaction is aborted, commands ignored until end of transaction block")
I tried with different variations of the argument type, but couldn't get this error to resolve.
There was a problem hiding this comment.
That's likely caused by the error in the statement beforehand. Either get a new connection here or reorder the test cases to first have those without error and then these that return an error.
valkrypton
force-pushed
the
feat/add/jsonb_object
branch
from
cdaec0c
to
ac30be5
Compare
weiznich
force-pushed
the
feat/add/jsonb_object
branch
from
ac30be5
to
307e9db
Compare
added support for
jsonb_object(text[])andjsonb_object(keys[], values[])under #4216