Moveable binds and rows #3977
Merged
Moveable binds and rows #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
reviewed
Apr 5, 2024
momobel
force-pushed
the
moveable_binds_and_row
branch
4 times, most recently
from
cccd84a
to
5da1637
Compare
weiznich
approved these changes
Apr 12, 2024
momobel
force-pushed
the
moveable_binds_and_row
branch
2 times, most recently
from
3e20b51
to
db0eb9b
Compare
It will be a hard error in 2024 edition so implement it "properly"
warning: creating a mutable reference to mutable static is discouraged
--> diesel/src/sqlite/connection/mod.rs:229:18
|
229 | unsafe { &mut SQLITE_METADATA_LOOKUP }
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ mutable reference to mutable static
|
= note: for more information, see issue #114447 <rust-lang/rust#114447>
= note: this will be a hard error in the 2024 edition
= note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior
= note: `#[warn(static_mut_refs)]` on by default
momobel
force-pushed
the
moveable_binds_and_row
branch
from
db0eb9b
to
e2c2c11
Compare
weiznich
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of diesel_async, an async connection would also like to be used with sqlite. To enable creating an async connection wrapping a syn connection some types needs to be moveable and/or owned.
This PR adds support for moveable binds and owned row in core Diesel types as well as the sqlite connection and backend.
Support for postgres was tested at compile time but crashed due to invalid
Rcconstraints. That would need some deeper look to properly implement but doesn't seem to be blocking.