Add implicit sqlite rowid columns to print-schema output #3926
Conversation
longsleep
force-pushed
the
longsleep-sqlite-fix-implicit-rowid
branch
from
11d4b4f
to
e502cbb
Compare
longsleep
force-pushed
the
longsleep-sqlite-fix-implicit-rowid
branch
from
e502cbb
to
03c4fad
Compare
|
Can you rebase the branch to pull in the latest changes (to fix the CI)? |
longsleep
force-pushed
the
longsleep-sqlite-fix-implicit-rowid
branch
from
03c4fad
to
b7803b6
Compare
I have debased but the tests still fail with errors imo unrelated to the actual change. What needs to happen to get this merged? |
|
Seems like we have hit exactly that time window where a new stable rustc version dropped. That usually means that new lints fire off and cause issues. If you don't mind you can push a change that fixes that, otherwise I will try to take care of that later today. |
|
Can you rebase the PR again to pull in the fixes for the CI? |
Whenever sqlite uses an implicit rowid it also need to be added as column to the corresponding schema. This change fixes the implicit primary key generator added in diesel-rs#3680 which was never tested as the test added in this pull request never actually is run. This change enables the test and enhances the schema printer to generate the missing column if the primary key is an implicit rowid column. Related: diesel-rs#2149
Head branch was pushed to by a user without write access
longsleep
force-pushed
the
longsleep-sqlite-fix-implicit-rowid
branch
from
b7803b6
to
8c4fa4a
Compare
Whenever sqlite uses an implicit rowid it also need to be added as column to the corresponding schema. This change fixes the implicit primary key generator added in #3680 which was never tested as the test added in this pull request never actually is run.
This change enables the test and enhances the schema printer to generate the missing column if the primary key is an implicit rowid column.
Related: #2149