Fix impl SqlOrd postgres > postgres_backend feature flag. #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PostgreSQL types are included when using the postgres_backend feature flag, the same feature flag should be used for the SqlOrd implementation of these types.
|
@weiznich the last Diesel release has been quite some time ago and does not include this fix. Would it be possible to create a new release which includes this fix? Thanks in advance! |
weiznich
added
the
maybe backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for your excellent work!
I believe the
SqlOrdshould be implemented if thepostgres_backendis enabled, notpostgres. Else theSqlOrdtrait would not be implemented for these types if usingdiesel-asyc.