Improve code generated by the insertable derive #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the code generated by the insertable derive in such a way that error messages about field mismatches now point to the fields itself, instead to the derive.
weiznich
force-pushed
the
improve_insertable_error_messages
branch
from
8019195
to
a5ab9a3
Compare
pksunkara
approved these changes
Jul 15, 2022
| @@ -87,7 +87,7 @@ pub fn derive(item: DeriveInput) -> TokenStream { | |||
| { | |||
| type Values = <(#(#direct_field_ty,)*) as Insertable<#table_name::table>>::Values; | |||
|
|
|||
| fn values(self) -> Self::Values { | |||
| fn values(self) -> <(#(#direct_field_ty,)*) as Insertable<#table_name::table>>::Values { | |||
There was a problem hiding this comment.
It does need to change as otherwise rustc emits for whatever reason 2 error message, where one is pointing to the derive itself, and the other one to the corresponding field.
| @@ -105,8 +105,8 @@ pub fn derive(item: DeriveInput) -> TokenStream { | |||
| { | |||
| type Values = <(#(#ref_field_ty,)*) as Insertable<#table_name::table>>::Values; | |||
|
|
|||
| fn values(self) -> Self::Values { | |||
| (#(#ref_field_assign,)*).values() | |||
| fn values(self) -> <(#(#ref_field_ty,)*) as Insertable<#table_name::table>>::Values { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the code generated by the insertable derive in such
a way that error messages about field mismatches now point to the fields
itself, instead to the derive.
See here for the old error message: https://github.com/weiznich/rust-foundation-community-grant/blob/77f131de301a4a113c45db15c66e6247a3e4bee9/test_cases/tests/diesel/bad_insertable_field.stderr