Adding progressBorderColor property on progressBar #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/circular_percent_indicator.dart
Outdated
| _paintLine.style = PaintingStyle.stroke; | ||
| _paintLine.strokeWidth = lineWidth; | ||
| _paintLine.style = PaintingStyle.fill; | ||
| _paintLine.strokeWidth = lineWidth - 2; |
There was a problem hiding this comment.
Just for border size ... I think if it is dynamic, another problems will appear
|
thanks for making these changes, can you also update the examples, adding a few using this new property? thanks |
|
I make some changes to avoid percent border errors on linear. please verify and accept. Now with some examples |
|
|
|
Up |
|
@diegoveloper can you review this new PR pls? |
|
Thanks for the contribution!! I'm out of my city now but I'll publish this as a new version the next week. In the meantime you can point directly to the repo. |
|
thanks bro! |
|
Hi! When I set the |
|
@bardez hello! Can you please verify if using |
diegoveloper
added a commit
that referenced
this pull request
Nov 23, 2024
* Adding progressBorderColor property on progressBar (#196) * adding progressBorderColor on progressBar draw * fixing border colors on linear percent and adding examples * removing unnecessary parse comparsion on progress(double) * refactoring border correction symmetrics --------- Co-authored-by: Thiago Carvalho Ribeiro Bardez - TBA <[email protected]> * fix: divide 0 error when archType is not null (#200) * Check in linear percent indicator state is null if the size is null (#203) * Add function return current percent value if animation is true (#206) * Add an 'initialPercent' field to control the initial animation. (#209) * Update master.yml * Update release.yml --------- Co-authored-by: Bardez <[email protected]> Co-authored-by: Thiago Carvalho Ribeiro Bardez - TBA <[email protected]> Co-authored-by: fenghezhou <[email protected]> Co-authored-by: Victor Manuel Lagunas Franco <[email protected]> Co-authored-by: Le Anh Phi <[email protected]> Co-authored-by: Erik Fahlén <[email protected]>
diegoveloper
added a commit
that referenced
this pull request
Nov 23, 2024
* Adding progressBorderColor property on progressBar (#196) * adding progressBorderColor on progressBar draw * fixing border colors on linear percent and adding examples * removing unnecessary parse comparsion on progress(double) * refactoring border correction symmetrics --------- Co-authored-by: Thiago Carvalho Ribeiro Bardez - TBA <[email protected]> * fix: divide 0 error when archType is not null (#200) * Check in linear percent indicator state is null if the size is null (#203) * Add function return current percent value if animation is true (#206) * Add an 'initialPercent' field to control the initial animation. (#209) * Update master.yml * Update release.yml * Update release.yml --------- Co-authored-by: Bardez <[email protected]> Co-authored-by: Thiago Carvalho Ribeiro Bardez - TBA <[email protected]> Co-authored-by: fenghezhou <[email protected]> Co-authored-by: Victor Manuel Lagunas Franco <[email protected]> Co-authored-by: Le Anh Phi <[email protected]> Co-authored-by: Erik Fahlén <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to allow percent indicator uses a different border color