fix: specifying ids on elements (named destinations) #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 36c6ba3, the contents of pdfkit number_tree were mistakenly copied over react-pdf's copy of name_tree. These two files contain different classes: number_tree is used for marked content sequences, while name_tree is used for named destinations and embedded files.
🦋 Changeset detectedLatest commit: 34b6ffe The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
diegomura
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 36c6ba3#r137623912
Unfortunately I can't provide a REPL, because the REPL seems to run react-pdf in an older version. The bug was introduced in @react-pdf/[email protected] and led to our CI failure in ecamp/ecamp3#4495
Instead of a REPL, I added a regression test which at least uses the
idattribute (with a non-number value). Running this test with 3.1.1 would yield the errorunsupported number: NaN. This is because the name_tree class was wrongly changed to use parseInt instead ofnew String()in 36c6ba3.