Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wasm yoga #2505

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat: wasm yoga #2505

merged 1 commit into from
Jan 19, 2024

Conversation

diegomura
Copy link
Owner

@diegomura diegomura commented Jan 18, 2024

Uses loadYoga from yoga-layout main entrypoint to leverage wasm internal usage.

This is supposed to ship less code and also be more performant. In tests I couldn't see much of a difference to be honest, but it's cool we run flex engine in wasm code as it's supposed to be more performant. Maybe in larger documents will be more noticeable. It does not introduce breaking changes as layout process is already async

I'd appreciate some thoughts about this :) cc/ @wojtekmaj @jeetiss

Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: 035e56f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@react-pdf/renderer Minor
@react-pdf/layout Minor
@react-pdf/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wojtekmaj
Copy link
Contributor

From my ESM stuff perspective, that looks alright :D

@diegomura diegomura changed the title feat: wasn yoga feat: wasm yoga Jan 19, 2024
@diegomura diegomura merged commit 0f5c43f into master Jan 19, 2024
1 check passed
@diegomura diegomura deleted the dm/wasm-yoga branch January 19, 2024 22:24
mskec pushed a commit to mskec/react-pdf that referenced this pull request Feb 26, 2024
@moishinetzer
Copy link

This seems to have caused the following issue: #2589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants