-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate from Jest to Vitest #2495
Conversation
|
ac96bed
to
5ff82aa
Compare
fd92279
to
ad84b7a
Compare
@wojtekmaj Just to understand this better (not familiarized with vitest), the benefit of this is better support for ESM and more performant? About the latter I'm not so concern as the entire testsuite runs in like 6sec. Also curious how tight this lib is to vite, considering we don't use it here |
Actually, about performance, I tested this branch and tests take 50% more to run (9s). It's not bad either s not concerned, but still curious :) |
There are multiple reasons to go with Vitest. It's quickly raising popularity for good reasons. Better ESM support and better (and ever-improving) performance are some of them. The importance of the former is only going to get bigger, as more and more modules go ESM-only. Other benefits:
|
Hmmm, interesting. You're right that the overall run time has increased a bit, and this is while the individual tests run faster: Before: After: Before: After: This makes me convinced that while there is probably something I could still tweak, the more tests and the more complex they are, the faster Vitest will be in relation to Jest. |
Now it's 35% faster than Jest on CI! ;) |
* Go all-in with Jest ESM migration * Migrate from Jest to Vitest
Requires #2409.
Requires #2494.Migrates the entire monorepo from Jest to Vitest.