feat: enable PDFDownloadLink to Receive Anchor Props
#2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Pass ALL anchor tag props to the rendered anchor element -- EXCLUDING the reserved `href` attribute. - Improve the `onClick` type of `PDFDownloadLink`. - Minor cleanup in related files.
diegomura
reviewed
Jan 14, 2024
diegomura
changed the title
PDFDownloadLink to Receive Anchor PropsPDFDownloadLink to Receive Anchor Props
|
diegomura
reviewed
Jan 14, 2024
mskec
pushed a commit
to mskec/react-pdf
that referenced
this pull request
Feb 26, 2024
* feat: Enable `PDFDownloadLink` to Receive Anchor Props Changes: - Pass ALL anchor tag props to the rendered anchor element -- EXCLUDING the reserved `href` attribute. - Improve the `onClick` type of `PDFDownloadLink`. - Minor cleanup in related files. * feat: preserve doc var * fix: preserve blank line --------- Co-authored-by: Diego Muracciole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are a few reasons why someone might want to leverage all of the attributes available on the related anchor (
a) element forPDFDownloadLink. This PR makes this possible without ruining backwards compatibility (downloadis now legal;fileNameis still preserved; andfileNamewill yield todownloadif the attribute is explicitly added). The TS props were also updated for clarity.It might be useful to have this on the v2 and v3 versions? Since it seems like some people in the
react@18world are having a hard time? But I leave that to you guys.I considered adding
React.forwardReftoo, but I didn't want to dive through additional TS headaches. Might be worth considering later?Changes
hrefattribute.onClicktype ofPDFDownloadLink.