Decouple estimation from providing items and allow allocating a specific size #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split PoolItemProvider into ItemProvider and Estimator - ItemProvider should now return items of the specified size, and also reset items for reuse - Change the size logic to work on capacity instead of length - The EstimatorStats struct allows backwards compatibility with already written Estimator implementations - Hide AdaptivePool and ReaderBufferer for now, which might be re-written - AdaptivePool: add a GetWithSize method that will get an item from the sync.Pool and return it if it has at least the requested size, or otherwise drop it and allocate a new object with that size instead - ReaderBufferer: allow specifying the size of the preallocated buffer
diegommm
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 227 240 +13
=========================================
+ Hits 227 240 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit log