Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #140, remove undocumented feature #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jzuschlag
Copy link
Contributor

No description provided.

@diefenbach
Copy link
Owner

This breaks the test case: test_manage_add_property_option (lfs.manage.tests.ManageTestCase)

@jzuschlag
Copy link
Contributor Author

I don't see any reason in the test code why it should fail. I am using this code for quite some time on a production system (0.7.7) without any problems. You changed the special character to underscore for 0.8, 0.9 and master. I would prefer a more "special" character like '|', if we want to keep that feature. And please, note it in the docs.

@diefenbach
Copy link
Owner

Hi,

AFAIR, the test breaks whether it runs in production or not and it should be adapted. Furthermore, I can't see that the special character has been changed in any version branch.

If you want to have it documented, please add it to the documentation and send a PR as always.

Thanks
Kai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants