Create a service for definitions endpoints #842

cl0ete · 2024-06-19T15:20:39Z

Moved bulk of app/routes/definitions.py to app/services/definitions.py

app/services/definitions.py

github-actions · 2024-06-24T12:27:20Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	84	23	73%	133–169, 210–211, 322–353, 397–398
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
definitions.py	190	97	49%	64–137, 148–163, 182–189, 194–195, 214–243, 256–281, 290–318, 331–347, 359–365, 378–387, 410–411, 426–428, 492–543
revocation_registry.py	153	28	82%	117–142, 185–189, 356–360, 399–404, 437–441, 469–474
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_jsonld.py	59	16	73%	134–169
test_tenants.py	349	15	96%	186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	69	10	86%	93–108
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	12	73%	130–203
test_verifier.py	228	12	95%	658–729
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	37	69%	176, 270–351, 364–436
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	27	68%	104–129, 138–155, 172–181, 236–253
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
credentials.py	13	2	85%	11, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13926	1001	93%

Tests	Skipped	Failures	Errors	Time
992	10 💤	0 ❌	0 🔥	13m 29s ⏱️

github-actions · 2024-06-24T12:27:20Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	84	42	50%	76–92, 147, 167, 199–215, 253–284, 351, 383–418
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	12	70%	49–64, 98–99
definitions.py	190	124	35%	52, 55–61, 64–137, 142, 145–163, 174–201, 214–243, 309–310, 323, 326–348, 351–365, 371–392, 395–415, 418–428, 442–477, 534–535
revocation_registry.py	153	39	75%	117–142, 185–189, 356–360, 399–404, 437–441, 459–474, 480–489
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_jsonld.py	59	16	73%	134–169
test_revocation.py	93	61	34%	27–76, 89–106, 117–143, 155–180, 192–206, 218–255, 266–292
test_tenants.py	349	296	15%	27–63, 74–100, 111–155, 168–231, 242–286, 299–419, 428–466, 475–503, 512–553, 562–605, 616–659, 671–716, 727–798
test_wallet_dids.py	69	15	78%	93–108, 120–131
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	11	76%	39–116
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	55	54%	132–207, 216–224, 234–255, 289–349, 384–434
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	43	4	91%	73, 91, 123, 141
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	17	80%	154–155, 169, 181, 191–223, 252–253
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
credentials.py	13	2	85%	11, 18
retry_method.py	36	30	17%	15–36, 68–114
string.py	15	1	93%	24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13926	1487	89%

Tests	Skipped	Failures	Errors	Time
992	39 💤	0 ❌	0 🔥	5m 30s ⏱️

ff137

The different classes needs to be consolidated. Some can just be raw methods. Some make sense to move to their own modules. Some other methods can be moved to utils.

We don't use the class pattern a lot so far, but I think it is better, and generally good practice to have related methods together in a relevant class, as opposed to one giant service module with all the methods we need. Logger / controller can just be used directly

app/services/definitions.py

app/util/transaction_acked.py

app/services/definitions/credential_definition_publisher.py

app/util/assert_public_did.py

app/services/definitions/definitions.py

github-actions · 2024-06-26T09:20:29Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	84	23	73%	133–169, 210–211, 322–353, 397–398
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	153	28	82%	117–142, 185–189, 356–360, 399–404, 437–441, 469–474
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	46	22	52%	19–39, 47–53, 66–75, 89–91
definitions.py	97	52	46%	57–64, 69–70, 89–121, 134–166, 176–204, 268–319
schema_publisher.py	46	27	41%	31–104, 110–125
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_jsonld.py	59	16	73%	134–169
test_tenants.py	349	15	96%	186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	69	10	86%	93–108
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	12	73%	130–203
test_verifier.py	228	12	95%	658–729
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	37	69%	176, 270–351, 364–436
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	27	68%	104–129, 138–155, 172–181, 236–253
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	1	97%	24
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	8	56%	17–34
credentials.py	13	2	85%	11, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	29–30
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13967	1013	93%

Tests	Skipped	Failures	Errors	Time
992	10 💤	0 ❌	0 🔥	13m 46s ⏱️

github-actions · 2024-06-26T09:20:30Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	84	42	50%	76–92, 147, 167, 199–215, 253–284, 351, 383–418
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	12	70%	49–64, 98–99
revocation_registry.py	153	39	75%	117–142, 185–189, 356–360, 399–404, 437–441, 459–474, 480–489
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	46	32	30%	15–16, 19–39, 42–53, 59–80, 83–91
definitions.py	97	49	49%	51–76, 89–121, 195–196, 215–253, 310–311
schema_publisher.py	46	34	26%	18–19, 22–28, 31–104, 107–125
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_jsonld.py	59	16	73%	134–169
test_revocation.py	93	61	34%	27–76, 89–106, 117–143, 155–180, 192–206, 218–255, 266–292
test_tenants.py	349	296	15%	27–63, 74–100, 111–155, 168–231, 242–286, 299–419, 428–466, 475–503, 512–553, 562–605, 616–659, 671–716, 727–798
test_wallet_dids.py	69	15	78%	93–108, 120–131
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	11	76%	39–116
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	55	54%	132–207, 216–224, 234–255, 289–349, 384–434
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	43	4	91%	73, 91, 123, 141
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	17	80%	154–155, 169, 181, 191–223, 252–253
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	12	33%	14–35
check_endorser_connection.py	10	4	60%	14–23
credentials.py	13	2	85%	11, 18
retry_method.py	36	30	17%	15–36, 68–114
string.py	15	1	93%	24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	16–34
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13967	1501	89%

Tests	Skipped	Failures	Errors	Time
992	39 💤	0 ❌	0 🔥	4m 56s ⏱️

ff137

Looking good - just a variety of little change requests

app/util/check_endorser_connection.py

app/util/assert_public_did.py

app/services/definitions/schema_publisher.py

app/util/transaction_acked.py

app/services/definitions/schema_publisher.py

app/services/definitions/definitions.py

app/routes/definitions.py

app/services/definitions/definitions.py

app/services/definitions/schema_publisher.py

github-actions · 2024-07-02T09:54:51Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	91	27	70%	130–170, 211–212, 323–354, 398–399
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	153	28	82%	117–142, 185–189, 356–360, 399–404, 437–441, 469–474
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	35	12	66%	24–29, 41–54, 68–70
definitions.py	92	47	49%	55, 85–117, 130–166, 178–205, 269–320
schema_publisher.py	49	30	39%	28–35, 40–41, 49–121
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_jsonld.py	59	16	73%	134–169
test_tenants.py	349	15	96%	186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	69	10	86%	93–108
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	12	73%	130–203
test_verifier.py	228	12	95%	658–729
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	37	69%	176, 270–351, 364–436
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	27	68%	104–129, 138–155, 172–181, 236–253
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	8	56%	17–33
credentials.py	13	2	85%	11, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	31–32
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13966	1014	93%

Tests	Skipped	Failures	Errors	Time
992	10 💤	0 ❌	0 🔥	12m 50s ⏱️

github-actions · 2024-07-02T09:54:52Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	91	44	52%	81–89, 144, 161–163, 168, 200–216, 254–285, 352, 384–419
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	12	70%	49–64, 98–99
revocation_registry.py	153	39	75%	117–142, 185–189, 356–360, 399–404, 437–441, 459–474, 480–489
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	35	22	37%	15–16, 19–29, 35–59, 62–70
definitions.py	92	44	52%	50–72, 85–117, 141, 196–197, 216–254, 311–312
schema_publisher.py	49	37	24%	15–16, 21–44, 49–121
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_jsonld.py	59	16	73%	134–169
test_revocation.py	93	61	34%	27–76, 89–106, 117–143, 155–180, 192–206, 218–255, 266–292
test_tenants.py	349	296	15%	27–63, 74–100, 111–155, 168–231, 242–286, 299–419, 428–466, 475–503, 512–553, 562–605, 616–659, 671–716, 727–798
test_wallet_dids.py	69	15	78%	93–108, 120–131
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	11	76%	39–116
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	55	54%	132–207, 216–224, 234–255, 289–349, 384–434
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	43	4	91%	73, 91, 123, 141
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	17	80%	154–155, 169, 181, 191–223, 252–253
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	13	2	85%	11, 18
retry_method.py	36	30	17%	15–36, 68–114
string.py	15	1	93%	24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	18–36
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13966	1498	89%

Tests	Skipped	Failures	Errors	Time
992	39 💤	0 ❌	0 🔥	4m 28s ⏱️

github-actions · 2024-07-02T10:16:48Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	90	27	70%	129–169, 210–211, 322–353, 397–398
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	153	28	82%	117–142, 185–189, 356–360, 399–404, 437–441, 469–474
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	34	12	65%	23–28, 40–53, 67–69
definitions.py	92	47	49%	55, 85–117, 130–166, 178–205, 269–320
schema_publisher.py	49	30	39%	28–35, 40–41, 49–121
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_jsonld.py	59	16	73%	134–169
test_tenants.py	349	15	96%	186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	69	10	86%	93–108
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	12	73%	130–203
test_verifier.py	228	12	95%	658–729
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	37	69%	176, 270–351, 364–436
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	27	68%	104–129, 138–155, 172–181, 236–253
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	8	56%	17–33
credentials.py	13	2	85%	11, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	31–32
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13964	1014	93%

Tests	Skipped	Failures	Errors	Time
992	10 💤	0 ❌	0 🔥	12m 35s ⏱️

github-actions · 2024-07-02T10:16:49Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	90	44	51%	80–88, 143, 160–162, 167, 199–215, 253–284, 351, 383–418
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	12	70%	49–64, 98–99
revocation_registry.py	153	39	75%	117–142, 185–189, 356–360, 399–404, 437–441, 459–474, 480–489
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	34	22	35%	14–15, 18–28, 34–58, 61–69
definitions.py	92	44	52%	50–72, 85–117, 141, 196–197, 216–254, 311–312
schema_publisher.py	49	37	24%	15–16, 21–44, 49–121
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_jsonld.py	59	16	73%	134–169
test_revocation.py	93	61	34%	27–76, 89–106, 117–143, 155–180, 192–206, 218–255, 266–292
test_tenants.py	349	296	15%	27–63, 74–100, 111–155, 168–231, 242–286, 299–419, 428–466, 475–503, 512–553, 562–605, 616–659, 671–716, 727–798
test_wallet_dids.py	69	15	78%	93–108, 120–131
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	11	76%	39–116
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	55	54%	132–207, 216–224, 234–255, 289–349, 384–434
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	43	4	91%	73, 91, 123, 141
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	17	80%	154–155, 169, 181, 191–223, 252–253
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	13	2	85%	11, 18
retry_method.py	36	30	17%	15–36, 68–114
string.py	15	1	93%	24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	18–36
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13964	1498	89%

Tests	Skipped	Failures	Errors	Time
992	39 💤	0 ❌	0 🔥	4m 26s ⏱️

github-actions · 2024-07-02T12:46:58Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	90	27	70%	129–169, 210–211, 322–353, 397–398
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	153	28	82%	117–142, 185–189, 356–360, 399–404, 437–441, 469–474
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	34	12	65%	23–28, 40–53, 67–69
definitions.py	92	47	49%	55, 85–117, 130–166, 178–205, 269–320
schema_publisher.py	49	30	39%	28–35, 40–41, 49–121
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_jsonld.py	59	16	73%	134–169
test_tenants.py	349	15	96%	186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	69	10	86%	93–108
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	12	73%	130–203
test_verifier.py	228	12	95%	658–729
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	37	69%	176, 270–351, 364–436
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	27	68%	104–129, 138–155, 172–181, 236–253
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	8	56%	17–33
credentials.py	13	2	85%	11, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	31–32
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13964	1014	93%

Tests	Skipped	Failures	Errors	Time
992	10 💤	0 ❌	0 🔥	13m 26s ⏱️

github-actions · 2024-07-02T12:46:59Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	90	44	51%	80–88, 143, 160–162, 167, 199–215, 253–284, 351, 383–418
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	12	70%	49–64, 98–99
revocation_registry.py	153	39	75%	117–142, 185–189, 356–360, 399–404, 437–441, 459–474, 480–489
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	34	22	35%	14–15, 18–28, 34–58, 61–69
definitions.py	92	44	52%	50–72, 85–117, 141, 196–197, 216–254, 311–312
schema_publisher.py	49	37	24%	15–16, 21–44, 49–121
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_jsonld.py	59	16	73%	134–169
test_revocation.py	93	61	34%	27–76, 89–106, 117–143, 155–180, 192–206, 218–255, 266–292
test_tenants.py	349	296	15%	27–63, 74–100, 111–155, 168–231, 242–286, 299–419, 428–466, 475–503, 512–553, 562–605, 616–659, 671–716, 727–798
test_wallet_dids.py	69	15	78%	93–108, 120–131
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	11	76%	39–116
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	55	54%	132–207, 216–224, 234–255, 289–349, 384–434
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	43	4	91%	73, 91, 123, 141
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	17	80%	154–155, 169, 181, 191–223, 252–253
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	13	2	85%	11, 18
retry_method.py	36	30	17%	15–36, 68–114
string.py	15	1	93%	24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	18–36
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13964	1498	89%

Tests	Skipped	Failures	Errors	Time
992	39 💤	0 ❌	0 🔥	4m 38s ⏱️

sonarqubecloud · 2024-07-05T13:28:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

app/services/definitions/credential_definitions.py

ff137

I included some minor 🎨, mainly splitting services.definitions.definitions.py into schemas.py and credential_definitions.py, and then importing as schemas_service and cred_def_service in the routes module

github-actions · 2024-07-05T16:43:28Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	88	27	69%	120–160, 201–202, 313–344, 388–389
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	153	28	82%	117–142, 185–189, 356–360, 399–404, 437–441, 469–474
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	34	12	65%	23–29, 42–55, 69–71
credential_definitions.py	40	12	70%	81–132
schema_publisher.py	49	31	37%	32–40, 45–46, 54–126
schemas.py	60	35	42%	36, 66–98, 111–147, 159–187
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_jsonld.py	59	16	73%	134–169
test_tenants.py	349	15	96%	186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	69	10	86%	93–108
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	12	73%	130–203
test_verifier.py	228	12	95%	658–729
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	37	69%	176, 270–351, 364–436
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	27	68%	104–129, 138–155, 172–181, 236–253
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	8	56%	17–33
credentials.py	13	2	85%	11, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	31–32
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13970	1015	93%

Tests	Skipped	Failures	Errors	Time
992	10 💤	0 ❌	0 🔥	12m 42s ⏱️

github-actions · 2024-07-05T16:43:29Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	88	44	50%	71–79, 134, 151–153, 158, 190–206, 244–275, 342, 374–409
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	147	33	78%	94–96, 101, 161–163, 168, 244, 252–254, 259, 303–308, 314–316, 374–376, 382, 421–423, 428, 464–466, 508–510
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	12	70%	49–64, 98–99
revocation_registry.py	153	39	75%	117–142, 185–189, 356–360, 399–404, 437–441, 459–474, 480–489
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/definitions
credential_definition_publisher.py	34	22	35%	14–15, 18–29, 36–60, 63–71
credential_definitions.py	40	16	60%	28–66, 123–124
schema_publisher.py	49	38	22%	19–20, 25–49, 54–126
schemas.py	60	28	53%	31–53, 66–98, 122, 177–178
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_jsonld.py	59	16	73%	134–169
test_revocation.py	93	61	34%	27–76, 89–106, 117–143, 155–180, 192–206, 218–255, 266–292
test_tenants.py	349	296	15%	27–63, 74–100, 111–155, 168–231, 242–286, 299–419, 428–466, 475–503, 512–553, 562–605, 616–659, 671–716, 727–798
test_wallet_dids.py	69	15	78%	93–108, 120–131
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	45	11	76%	39–116
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	119	55	54%	132–207, 216–224, 234–255, 289–349, 384–434
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	43	4	91%	73, 91, 123, 141
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	150
test_send_credential.py	36	1	97%	129
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	135	2	99%	75, 106
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	85	17	80%	154–155, 169, 181, 191–223, 252–253
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	54	5	91%	19, 74–77, 100, 124
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	13	2	85%	11, 18
retry_method.py	36	30	17%	15–36, 68–114
string.py	15	1	93%	24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	18–36
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13970	1499	89%

Tests	Skipped	Failures	Errors	Time
992	39 💤	0 ❌	0 🔥	4m 29s ⏱️

cl0ete added the improvement improving on something that is already existing (not a new feature as such) label Jun 19, 2024

cl0ete self-assigned this Jun 19, 2024

github-advanced-security bot found potential problems Jun 19, 2024

View reviewed changes

cl0ete force-pushed the definitions-service branch from 52f5434 to eb24e28 Compare June 20, 2024 07:38

cl0ete requested a review from ff137 June 22, 2024 11:48

cl0ete marked this pull request as ready for review June 22, 2024 11:48

cl0ete had a problem deploying to dev June 22, 2024 11:50 — with GitHub Actions Failure

cl0ete had a problem deploying to dev June 22, 2024 12:20 — with GitHub Actions Failure

cl0ete marked this pull request as draft June 24, 2024 09:51

cl0ete marked this pull request as ready for review June 24, 2024 11:56

cl0ete temporarily deployed to dev June 24, 2024 11:57 — with GitHub Actions Inactive

ff137 requested changes Jun 24, 2024

View reviewed changes

ff137 marked this pull request as draft June 24, 2024 19:22

github-advanced-security bot found potential problems Jun 25, 2024

View reviewed changes

cl0ete force-pushed the definitions-service branch from d181e8e to d729d02 Compare June 26, 2024 08:56

cl0ete marked this pull request as ready for review June 26, 2024 08:56

cl0ete temporarily deployed to dev June 26, 2024 08:57 — with GitHub Actions Inactive

cl0ete requested a review from ff137 June 26, 2024 09:08

ff137 requested changes Jun 26, 2024

View reviewed changes

ff137 marked this pull request as draft June 26, 2024 11:06

github-advanced-security bot found potential problems Jun 27, 2024

View reviewed changes

app/routes/definitions.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jun 27, 2024

View reviewed changes

app/routes/definitions.py Fixed Show fixed Hide fixed

cl0ete added 4 commits June 27, 2024 16:33

move to service

0af2d9f

move to service and call service based on tenant

bd1b29f

move to service , call create from service

797d1d3

move to service and call service here

5218065

move error handling here

6f1cfa2

cl0ete temporarily deployed to dev July 2, 2024 09:32 — with GitHub Actions Inactive

remove unused imports

cfe7147

cl0ete temporarily deployed to dev July 2, 2024 09:34 — with GitHub Actions Inactive

github-advanced-security bot found potential problems Jul 2, 2024

View reviewed changes

app/services/definitions/definitions.py Fixed Show fixed Hide fixed

app/services/definitions/schema_publisher.py Dismissed Show dismissed Hide dismissed

cl0ete temporarily deployed to dev July 2, 2024 12:24 — with GitHub Actions Inactive

cl0ete requested a review from ff137 July 2, 2024 12:48

ff137 added 7 commits July 5, 2024 16:13

🎨 init file

fe4fe7c

🚚 move schema specific methods to own module

8848b13

🎨 rename module for clarity

8afcc47

🎨 update imports and method references

adf9102

🎨 rearrange if condition

537776c

🎨 fit in max lines

6b757c5

Merge branch 'development' into definitions-service

9da5dfb

ff137 had a problem deploying to dev July 5, 2024 13:29 — with GitHub Actions Failure

github-advanced-security bot found potential problems Jul 5, 2024

View reviewed changes

app/services/definitions/credential_definitions.py Dismissed Show dismissed Hide dismissed

app/services/definitions/credential_definitions.py Dismissed Show dismissed Hide dismissed

ff137 approved these changes Jul 5, 2024

View reviewed changes

ff137 had a problem deploying to dev July 5, 2024 14:48 — with GitHub Actions Failure

ff137 temporarily deployed to dev July 5, 2024 16:27 — with GitHub Actions Inactive

ff137 merged commit 9fbca0f into development Jul 5, 2024
45 checks passed

ff137 deleted the definitions-service branch July 5, 2024 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a service for definitions endpoints #842

Create a service for definitions endpoints #842

cl0ete commented Jun 19, 2024

github-actions bot commented Jun 24, 2024

github-actions bot commented Jun 24, 2024

ff137 left a comment

github-actions bot commented Jun 26, 2024

github-actions bot commented Jun 26, 2024

ff137 left a comment

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

sonarqubecloud bot commented Jul 5, 2024

ff137 left a comment

github-actions bot commented Jul 5, 2024

github-actions bot commented Jul 5, 2024

Create a service for definitions endpoints #842

Create a service for definitions endpoints #842

Conversation

cl0ete commented Jun 19, 2024

github-actions bot commented Jun 24, 2024

github-actions bot commented Jun 24, 2024

ff137 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 26, 2024

github-actions bot commented Jun 26, 2024

ff137 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

sonarqubecloud bot commented Jul 5, 2024

Quality Gate passed

ff137 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 5, 2024

github-actions bot commented Jul 5, 2024