修复swiper-current变化滚动问题 #1684
Merged
修复swiper-current变化滚动问题 #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Nov 1, 2024
| const { nextIndex, nextOffset } = getMultiNextConfig(props.current) | ||
| // 1. 安卓需要主动更新下内部状态, 2. IOS不能触发完wcrollTo之后立即updateState, 会造成滑动两次 | ||
| // 2. setTimeout 是fix 当再渲染过程中触发scrollTo失败的问题 | ||
| if (Platform.OS === 'ios') { |
There was a problem hiding this comment.
平台判断统一走__mpx_mode__判断，便于treeShaking
hiyuki
reviewed
Nov 1, 2024
| @@ -486,7 +488,6 @@ const _Carouse = forwardRef<HandlerRef<ScrollView & View, CarouseProps>, Carouse | |||
| } else if (i === pages.length - 1 && typeof width === 'number') { | |||
| nextMargin && (extraStyle.marginRight = nextMargin) | |||
| } | |||
| // return (<View style={[pageStyle, styles.slide, extraStyle]} key={ 'page' + i}>{children[+page]}</View>) | |||
| return (<View style={[pageStyle, styles.slide, extraStyle]} key={ 'page' + i}> | |||
| {wrapChildren( | |||
hiyuki
reviewed
Nov 1, 2024
| @@ -486,7 +488,6 @@ const _Carouse = forwardRef<HandlerRef<ScrollView & View, CarouseProps>, Carouse | |||
| } else if (i === pages.length - 1 && typeof width === 'number') { | |||
| nextMargin && (extraStyle.marginRight = nextMargin) | |||
| } | |||
| // return (<View style={[pageStyle, styles.slide, extraStyle]} key={ 'page' + i}>{children[+page]}</View>) | |||
| return (<View style={[pageStyle, styles.slide, extraStyle]} key={ 'page' + i}> | |||
| {wrapChildren( | |||
| { | |||
There was a problem hiding this comment.
下面为啥又有normalStyle又有innerstyle?
hiyuki
reviewed
Nov 1, 2024
| @@ -461,20 +462,21 @@ const _Carouse = forwardRef<HandlerRef<ScrollView & View, CarouseProps>, Carouse | |||
| } | |||
|
|
|||
| function renderPages () { | |||
| const { width, height, total, children } = state | |||
| const { width, height } = state | |||
| const { children } = props | |||
hiyuki
reviewed
Nov 1, 2024
| @@ -254,13 +267,12 @@ const _Carouse = forwardRef<HandlerRef<ScrollView & View, CarouseProps>, Carouse | |||
| createAutoPlay() | |||
| return | |||
| } | |||
| if (!Array.isArray(state.children)) { | |||
| if (!Array.isArray(props.children)) { | |||
There was a problem hiding this comment.
这里newChild才等价于state.children，以及把newChild重命名为children
hiyuki
reviewed
Nov 1, 2024
| @@ -394,7 +395,7 @@ const _Carouse = forwardRef<HandlerRef<ScrollView & View, CarouseProps>, Carouse | |||
| const scrollElementProps = { | |||
| ref: scrollViewRef, | |||
| horizontal: props.horizontal, | |||
| pagingEnabled: false, | |||
| pagingEnabled: true, | |||
There was a problem hiding this comment.
下面这个scrollView为啥要用animated的？
hiyuki
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.