Feat intersection observer #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Oct 14, 2024
packages/core/src/platform/patch/react/getDefaultOptions.ios.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 14, 2024
packages/core/src/platform/patch/react/getDefaultOptions.ios.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
| // 初次调用的 | ||
| if (isCallback) { | ||
| this.callback({ | ||
| index: index, |
hiyuki
reviewed
Oct 24, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
packages/core/src/platform/patch/react/getDefaultOptions.ios.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 24, 2024
| top: navigation.isCustomHeader ? this.margins.top : navigation.headerHeight, | ||
| left: this.margins.left, | ||
| right: screen.width - this.margins.right, | ||
| bottom: navigation.layout.height + navigation.headerHeight - this.margins.bottom |
There was a problem hiding this comment.
vh 使用navigation.layout 因为是异步在初始计算的时候还是会不符合预期，后续才是对的
added 6 commits
October 28, 2024 11:19
hiyuki
reviewed
Oct 31, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 31, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 31, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 31, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 31, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Outdated
Show resolved
Hide resolved
hiyuki
reviewed
Oct 31, 2024
packages/api-proxy/src/platform/api/create-intersection-observer/rnIntersectionObserver.js
Show resolved
Hide resolved
hiyuki
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加相交API功能