Feat dynamic v2 #1486
Merged
Feat dynamic v2 #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/ali support
hiyuki
reviewed
Jun 27, 2024
| el.ifConditions.push(condition) | ||
| } | ||
|
|
||
| function getAttrExps (attr) { |
hiyuki
reviewed
Jun 27, 2024
| } | ||
| } | ||
|
|
||
| function processShowStyleDynamic (el, show) { |
There was a problem hiding this comment.
把processShowStyle也提出来吧，格式统一一点
hiyuki
reviewed
Jun 27, 2024
| @@ -1842,6 +1852,12 @@ function processAliAddComponentRootView (el, options) { | |||
| el = postProcessComponentIs(el) | |||
| } | |||
|
|
|||
| if (options.runtimeCompile) { | |||
| postProcessDynamic(el, config[mode]) | |||
| processAttrsDynamic(componentWrapView, config[mode]) | |||
hiyuki
reviewed
Jun 27, 2024
| vnode.attrsList.splice(i, 1) | ||
| } else if (attr.value == null) { | ||
| const exp = parseMustacheWithContext('{{ true }}').result | ||
| attr.__exps = parseExp(exp) |
There was a problem hiding this comment.
__exps改为__exp吧，现在应该都是单个吧，这里不用parseMustache直接parseExp('true')就可以了吧
hiyuki
reviewed
Jun 27, 2024
| } | ||
|
|
||
| function postProcessAttrsDynamic (vnode, config) { | ||
| const expsMap = Object.fromEntries(vnode.exps?.map(v => ([v.attrName, v])) || []) |
There was a problem hiding this comment.
exps中的item从设计上讲不一定都有attrName，需要filter一下
hiyuki
reviewed
Jun 27, 2024
| const attr = vnode.attrsList[i] | ||
| if (config.event.parseEvent(attr.name)) { | ||
| // 原本的事件代理直接剔除，主要是基础模版的事件直接走代理形式，事件绑定名直接写死的，优化 astJson 体积 | ||
| vnode.attrsList.splice(i, 1) |
There was a problem hiding this comment.
这里也可以直接调用getAndRemoveAttrs来删除
fix: cr change
…ture/merge-master-confict
fix: merge master ali process order
fix: postMoveBaseDirective options
hiyuki
reviewed
Jun 27, 2024
| postMoveBaseDirective(componentWrapView, el, options) | ||
|
|
||
| if (options.runtimeCompile) { | ||
| processAttrs(componentWrapView, options) |
There was a problem hiding this comment.
processAttrs应该在非runtime情况下也需要跑一遍，放在postMoveBaseDirective前面吧
hiyuki
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.