Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swiper,tab-bar): fix resize behavior #602

Merged
merged 3 commits into from
Nov 2, 2019
Merged

Conversation

zouhangwithsweet
Copy link
Collaborator

背景描述

修复 #599resize事件导致的若干问题

主要改动

主要在 swipertabBar两个组件中, 在activateddeactivated两个生命周期 进行 resize 事件的绑定与解绑

需要注意

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #602 into dev will increase coverage by 1.93%.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #602      +/-   ##
=========================================
+ Coverage   81.3%   83.23%   +1.93%     
=========================================
  Files         98       98              
  Lines       2835     2774      -61     
  Branches     553      528      -25     
=========================================
+ Hits        2305     2309       +4     
+ Misses       374      318      -56     
+ Partials     156      147       -9
Impacted Files Coverage Δ
components/tab-bar/index.vue 88.13% <57.14%> (+0.41%) ⬆️
components/swiper/index.vue 83.9% <89.47%> (+16.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00bc37...2275b3b. Read the comment docs.

@xxyan0205 xxyan0205 merged commit 2ed1f8a into dev Nov 2, 2019
@xxyan0205 xxyan0205 deleted the fix_resize_behavior branch November 2, 2019 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants