Pulling feat/editor-links into develop #771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…inking feature The AutoLinkNode import was added to the editorConfig.ts file to support the automatic linking feature in the editor. This allows for easier and more convenient linking within the editor without the need for manual input of link nodes.
The InsertLinkButton component has been added to the project to provide a button with an insert link icon for use in the editor toolbar. This new component enhances the functionality of the editor toolbar by allowing users to easily insert links into the editor content.
…Toolbar The InsertLinkButton component has been added to the DictybaseToolbar, enhancing the functionality of the toolbar by providing users with the ability to insert links into the editor content.
…tton with InsertLinkIcon The incorrect component name was used in the IconButton component, which was causing a rendering issue. By replacing it with the correct component name, InsertLinkIcon, the button now displays the intended icon correctly.
… editor when the InsertLinkButton is clicked The InsertLinkButton component now includes functionality to insert a link in the editor when the button is clicked. This is achieved by updating the editor state on click to toggle a link and insert the specified link text. This enhancement improves the user experience by providing a convenient way to add links within the editor.
The ts-pattern package has been added as a dependency to the editor-toolbar package to introduce pattern matching capabilities in the codebase. This addition enhances the functionality and flexibility of the editor-toolbar package by leveraging the features provided by the ts-pattern library.
…anage link properties in the editor toolbar The useLinkProperties custom hook is added to handle link properties in the editor toolbar. It utilizes Jotai for state management and provides a function to determine if a selected text contains a link node parent. This hook enhances the functionality of the editor toolbar by enabling link-related operations.
…tor toolbar The isLinkAtom is added to the editor toolbar context to manage the state of whether a selected text should be formatted as a link. This new atom allows for better control and management of link formatting within the editor toolbar.
…he toolbar The useUpdateToolbar hook now includes a new function call to updateLinkProperties, which allows for updating link properties in the toolbar. This enhancement provides additional functionality to the toolbar by enabling users to modify link properties seamlessly.
…editor The LinkPlugin is added to the Editor component to provide support for adding hyperlinks within the editor. This enhancement allows users to easily insert and manage hyperlinks in the content being edited.
… based on isLink state The code now includes functionality to toggle link creation based on the isLink state. When the isLink state is true, the editor will dispatch the TOGGLE_LINK_COMMAND with a null value. When the isLink state is false, the editor will dispatch the TOGGLE_LINK_COMMAND with an empty string. This change enhances the InsertLinkButton component's behavior by dynamically handling link creation based on the isLink state.
…LinkButton for editing link functionality The changes in this commit focus on improving the code style by organizing imports and formatting the code for better readability. Additionally, a new EditingLinkPopper component is added to the InsertLinkButton component to provide functionality for editing links within the editor toolbar.
… handle link editing functionality The EditingLinkPopper component is added to the project to handle link editing functionality within the editor toolbar. It utilizes various libraries and functions from fp-ts and lexical to manage the anchor element for the popper, determine if a link is present, and control its appearance based on certain conditions. The component listens for editor state updates and dynamically sets the anchor element for the popper to display a TextField for editing links.
… consistency The variable shouldAppear has been renamed to isOpen for better clarity and consistency with the purpose of the variable. Additionally, comments have been added to explain the necessity of setting the anchorElement before opening the Popper component.
…te and useEffect The code has been refactored to remove the unused state and useEffect related to setting the anchorElement. This optimization simplifies the component logic and improves code readability by eliminating unnecessary complexity.
…the IconButton element The useRef hook is added to manage a reference to the IconButton element in the InsertLinkButton component. This allows for more control over the element, such as accessing its properties or methods.
|
Important Review SkippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.