Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow silencing of unittest assertions #762

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

Jason2605
Copy link
Member

Assert Silence

The new list sort tests are pretty loud since we're checking 2000 elements. This allows us to silence on an assertion by assertion basis to stop those tests being pretty busy.

Also few docs updates to try to standardise types having capitals

What's Changed:

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

Copy link
Contributor

@briandowns briandowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jason2605 Jason2605 merged commit f07699f into develop Dec 9, 2024
9 checks passed
@Jason2605 Jason2605 deleted the feature/assert_silence branch December 9, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants