Feat: Buffer api #731
Feat: Buffer api #731
Conversation
|
This is super cool. Reminds me that we still need to get that native bytes type implemented. As for the PR, I'll refrain from commenting until you're ready but I'll mention there's a few places that still have the original code / names from the copy/paste. I do the exact same thing. :) Side note, and happy to take to a different forum like the discussion section but would love to understand your uses of Dictu! |
|
I wonder mostly if theres a way to reduce the copy paste for the integer methods which currently take up the majority of the file and only contain very small differences, thinking to have a generalised read/write to reduce it and then just have the typecast to the correct integer type. Regarding forum you can mail me: [email protected] or discord: liz3 |
|
Damn yeah this looks really neat! What I'll do with it being WIP is mark it as draft, then just mark it as ready whenever you're good to go! |
|
Sorry for being slow on this! @briandowns be good to get your thoughts on this one too if you get a spare moment! |
src/optionals/buffer.c
Outdated
| void grayBuffer(DictuVM *vm, ObjAbstract *abstract) { | ||
| (void)vm; | ||
| Buffer *ffi = (Buffer *)abstract->data; | ||
|
|
||
| if (ffi == NULL) | ||
| return; | ||
| } |
There was a problem hiding this comment.
This shouldn't be needed as we aren't holding any objects that could get GC'd within the buffer
src/optionals/buffer.c
Outdated
|
|
||
| void freeBuffer(DictuVM *vm, ObjAbstract *abstract) { | ||
| Buffer *buffer = (Buffer *)abstract->data; | ||
| free(buffer->bytes); |
There was a problem hiding this comment.
We want to try to use the macro FREE / ALLOCATE where possible, in theory it means in the future if we ever want to swap out the memory allocation methods it should be a single place swap
src/optionals/buffer.c
Outdated
| vm, "size must be greater than 0 and smaller than 2147483647"); | ||
| } | ||
| Buffer *buffer = AS_BUFFER(args[0]); | ||
| buffer->bytes = realloc(buffer->bytes, capacity); |
src/optionals/buffer.c
Outdated
|
|
||
| Buffer *buffer = ALLOCATE(vm, Buffer, 1); | ||
| buffer->bigEndian = false; | ||
| buffer->bytes = calloc(1, capacity); |
Should be addressed. |
|
Why do the tests for *nix likes take 2 hrs? Is this coming from my changes or githubs runners? |
|
My guess is that it's the runners. On Linux, MacOS, and FreeBSD, (locally) the suite runs very quickly. |
|
Thanks so much for this! |
Buffer API
What's Changed:
Implements a Buffer API inspired by Node.js's buffer api, including writing strings and all integer types.
Sadly even though i tried to reduce it as far as i could theres a loooot of duplication because of the fact there are 4 integer types, im open to suggestions which can help reduce the duplication.
Note: I commited
.clang-formatbecause thats the formatter i use and it's default setting is set to 2 spaces and so i thought it might be useful, can remove if not neededType of Change:
Housekeeping:
Screenshots (If Applicable):