Feature/more string methods #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies I will get around to this! Will try my best to have a look tomorrow for you mate |
At your leisure. No rush. :D |
Jason2605
reviewed
Jan 17, 2024
| testStringCollapseSpaces() { | ||
| const testString = "This is a huge string of a lot of spaces."; | ||
| const expected = "This is a huge string of a lot of spaces."; | ||
| const res = testString.collapseSpaces(); |
There was a problem hiding this comment.
Probably worth adding some tests to ensure the original string is also untouched
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
briandowns
force-pushed
the
feature/more_string_methods
branch
from
e0f3348 to
c01149d
Compare
|
Thanks for this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed:
Adds collapseSpaces and wrap methods to string type.
Type of Change:
Housekeeping:
Screenshots (If Applicable):