Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Clipboard read\write retry attempts on failure #665

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

LexiconCode
Copy link
Member

@LexiconCode LexiconCode commented Jul 29, 2019

Clipboard read\write retry attempts on failure

Description

Windows clipboard is a shared resource and can be locked by an application at any moment.

Related Issue

Should address #657 OpenClipboard: Access denied

Motivation and Context

On failure the clipboard limited loops read write until success.
These changes could be integrated directly into dragonfly. Eliminating the need for these modifications.

https://github.com/dictation-toolbox/dragonfly/blob/7018e5c1c5c4249e8ec1ae47d12505f2bfd02764/dragonfly/actions/action_paste.py#L103
https://github.com/dictation-toolbox/dragonfly/blob/master/dragonfly/windows/clipboard.py

How Has This Been Tested

Needs to be tested with a broader audience given the rarity of the bug.

Types of changes

  • Bug fix (non-breaking change which fixes an issue or bug)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have checked that my code does not duplicate functionality elsewhere in Caster.
  • I have checked for and utilized existing command phrases from within Caster (delete if not applicable).
  • My code implements all the features I wish to merge in this pull request.

Maintainer/Reviewer Checklist

  • Basic functionality has been tested and works as claimed.
  • New documentation is clear and complete.
  • Code is clear and readable.

@LexiconCode LexiconCode added Enhancement Enhancement of an existing feature Testing Required Requesting testers before merge Caster Issues pertaining to primarily the Caster project. labels Jul 29, 2019
@LexiconCode LexiconCode self-assigned this Jul 29, 2019
@LexiconCode LexiconCode added Bug Unexpected behavior from existing features. and removed Enhancement Enhancement of an existing feature labels Jul 29, 2019
@LexiconCode
Copy link
Member Author

LexiconCode commented Aug 13, 2019

If there is no feedback from the community this will merged in 48 hours.

@alexboche
Copy link
Contributor

Just mentioning a related issue #609 which is about pause times for copying (and less importantly, pasting) to the clipboard.

@LexiconCode LexiconCode merged commit 9c74ed9 into dictation-toolbox:master Aug 14, 2019
@LexiconCode LexiconCode deleted the clipboard_retry branch August 14, 2019 18:16
@LexiconCode LexiconCode removed the Testing Required Requesting testers before merge label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected behavior from existing features. Caster Issues pertaining to primarily the Caster project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants