Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed output of Retrieve() from Text to dragonfly Paste action #652

Merged

Conversation

LexiconCode
Copy link
Member

@LexiconCode LexiconCode commented Jul 16, 2019

Description

Changed output of Retrieve() from text to dragonfly paste action

Motivation and Context

Text(output).execute() vs Paste(output).execute()

Current implementation Text(output).execute() for Retrieve() does not handle multiline text. This is not noticeable except for applications where pressing enter sends text. E.G chat application like Gitter. Text seems to use enter key between each line. This means if you Retrieve() a multiline text it sends each line as its own message.

To work around this dragonfly Paste achieves the same functional purpose of text without the drawbacks mentioned.

How Has This Been Tested

I've tested this with multiline and single-line text fields with varying implementations of Store() Retrieve() and in gitter/sublime.

Types of changes

  • Bug fix (non-breaking change which fixes an issue or bug)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have checked that my code does not duplicate functionality elsewhere in Caster.
  • My code implements all the features I wish to merge in this pull request.
  • All new and existing tests pass.

Maintainer/Reviewer Checklist

  • Basic functionality has been tested and works as claimed.
  • New documentation is clear and complete.
  • Code is clear and readable.

@LexiconCode LexiconCode added the Enhancement Enhancement of an existing feature label Jul 16, 2019
@LexiconCode LexiconCode self-assigned this Jul 16, 2019
@LexiconCode LexiconCode added the Bug Unexpected behavior from existing features. label Jul 16, 2019
@LexiconCode LexiconCode mentioned this pull request Jul 16, 2019
14 tasks
@LexiconCode LexiconCode merged commit beffc33 into dictation-toolbox:master Jul 16, 2019
@LexiconCode LexiconCode deleted the store/retrieve_enhancement branch July 16, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected behavior from existing features. Enhancement Enhancement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant