Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new legion dll #602

Merged
merged 3 commits into from
Jul 1, 2019
Merged

new legion dll #602

merged 3 commits into from
Jul 1, 2019

Conversation

kendonB
Copy link
Collaborator

@kendonB kendonB commented Jun 25, 2019

recompiled this with the updated VS toolchain. It seems to work marginally faster now. Would be good to get some other "Legion" users to test though.

@LexiconCode LexiconCode added Caster Issues pertaining to primarily the Caster project. Enhancement Enhancement of an existing feature labels Jun 25, 2019
@LexiconCode
Copy link
Member

Fantastic, I have a 4K monitor. Legion takes a bit more time with higher resolutions.

@LexiconCode
Copy link
Member

I'm not really seeing the speed difference at least at a higher resolution but it works as expected. I suppose we could put timeit functions to empirically test.

@kendonB
Copy link
Collaborator Author

kendonB commented Jun 25, 2019

@seekM does this change make legion work for you?

@LexiconCode
Copy link
Member

LexiconCode commented Jun 26, 2019

@kendonB Does it change which version of Visual C++ Redistributable packages is required? Historically that is been Visual Studio 2013 (x86).

It would be nice to bump the version requirement to Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019. which I believe comes with Windows 10 nowadays.

@kendonB
Copy link
Collaborator Author

kendonB commented Jun 26, 2019

I'm not sure of the answer to that. I can test it out in a few days by selectively deleting VS packages.

@kendonB
Copy link
Collaborator Author

kendonB commented Jun 29, 2019

@LexiconCode I've deleted all of the VS Redistributable packages and legion still works regardless. It's possible that the underlying dependency is built into Windows 10 now. I will also check on my Windows 7 machine.

@kendonB
Copy link
Collaborator Author

kendonB commented Jun 30, 2019

I can't get any of these to work on my Win 7 machine. I tried the old dll, the new one in this PR, and also built a new one on my Win 7 machine. None worked. Win 7 is not long for this world, so this is only a short-term problem.

@LexiconCode
Copy link
Member

I can't get any of these to work on my Win 7 machine. I tried the old dll, the new one in this PR, and also built a new one on my Win 7 machine. None worked. Win 7 is not long for this world, so this is only a short-term problem.

Excellent I think we can live with that. It should be documented somewhere...

@LexiconCode LexiconCode reopened this Jun 30, 2019
@LexiconCode LexiconCode changed the base branch from develop to master June 30, 2019 20:45
@kendonB
Copy link
Collaborator Author

kendonB commented Jul 1, 2019

I have also confirmed that the old .dll works just fine on my Windows 10 computer. So installing the redistributable packages may help some people who aren't otherwise up-to-date but the current pull request doesn't seem to change the requirement (because there is no requirement any more). I've added some documentation to the installation file.

Those who want to compile this for themselves can do:

  • git clone https://github.com/kendonB/tirg-dll
  • Build the project using Visual Studio Community 2019 with C++ build tools (free download) choosing "Release" rather than "Debug" as the build setting. Ctrl-Shift-B is the build command.

It would also be good at point to get this dll built by travis.

@LexiconCode LexiconCode merged commit bddeae0 into dictation-toolbox:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caster Issues pertaining to primarily the Caster project. Enhancement Enhancement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants