-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new legion dll #602
new legion dll #602
Conversation
Fantastic, I have a 4K monitor. Legion takes a bit more time with higher resolutions. |
I'm not really seeing the speed difference at least at a higher resolution but it works as expected. I suppose we could put timeit functions to empirically test. |
@seekM does this change make legion work for you? |
@kendonB Does it change which version of Visual C++ Redistributable packages is required? Historically that is been Visual Studio 2013 (x86). It would be nice to bump the version requirement to Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019. which I believe comes with Windows 10 nowadays. |
I'm not sure of the answer to that. I can test it out in a few days by selectively deleting VS packages. |
@LexiconCode I've deleted all of the VS Redistributable packages and legion still works regardless. It's possible that the underlying dependency is built into Windows 10 now. I will also check on my Windows 7 machine. |
I can't get any of these to work on my Win 7 machine. I tried the old dll, the new one in this PR, and also built a new one on my Win 7 machine. None worked. Win 7 is not long for this world, so this is only a short-term problem. |
Excellent I think we can live with that. It should be documented somewhere... |
I have also confirmed that the old .dll works just fine on my Windows 10 computer. So installing the redistributable packages may help some people who aren't otherwise up-to-date but the current pull request doesn't seem to change the requirement (because there is no requirement any more). I've added some documentation to the installation file. Those who want to compile this for themselves can do:
It would also be good at point to get this dll built by travis. |
recompiled this with the updated VS toolchain. It seems to work marginally faster now. Would be good to get some other "Legion" users to test though.