-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caster GUI settings window does not launch #327
Comments
Works prior to |
I'm getting this on my normal branch, which is way behind #262. Increasing the time out didn't fix it. |
Try deleting the settings.toml. if you've added any customizations is it may cause the same issue. |
Still getting the same thing in both the |
Therefore I'm left with the conclusion that UI cannot parse some of the new fields. Hopefully that gives a clear picture of the process I was using to test. |
I cant imagine what would be causing it to be different on both of our machines. |
Okay I'm not sure what to say but it works on the main branch for me as well. Hmmm it's going to require some thought. In addition a few other people to test would be helpful to see a trend. |
I can confirm. From inspecting the code it looks like the settings window traverses the settings file for all settings and lists them in the GUI, assuming that all lists contain strings only. I did not know that, all the more reason to move the format definitions outside the settings file where they frankly don't belong. I was thinking about may be introducing a default TOML file for CCR grammars for this purpose( and may be for listing default enabled grammars, like the core ones ) So TL;DR it was introduced by #262 and the solution looks not too difficult, but not right now, I am not too energetic |
Yeah it's one of those undocumented features I forgot about over the mists of time. So I think it's a good plan to move it out into its own file. There's really no rush. |
…ger lists. This is a simple extension of the existing functionality in order to address dictation-toolbox#327. A proper solution would require rewriting much of the settings window code.
If the goal is to make the settings files human editable then I think it would make more sense to have the format lists as descriptive strings rather than plain integers.
instead of
|
That does indeed make a lot of sense. |
Indeed. I have just broken down the lists, like
which is a little more verbose, but avoids lists entirely. I might use the strings here? |
For clarification, I mean the strings with this setup:
Question: "atom_palette_wait" being string is just some kind of typo right? A detail, but might confuse something. For example, making the entry fields for numbers accept only numbers might not be ridiculous. |
"atom_palette_wait" was not intended as a typo. although I agree it should be converted to an integer if it works as intended. Try converting it to an integer in the settings and convert it in caster\apps\atom.py as well. |
Closed by #329. |
Caster has a GUI for settings does not launch. To test use Spec "launch settings window"
The text was updated successfully, but these errors were encountered: