Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legion grid uses incorrect screen capture on secondary monitors #116

Closed
chilimangoes opened this issue Oct 29, 2015 · 3 comments
Closed
Assignees
Labels
Bug Unexpected behavior from existing features.

Comments

@chilimangoes
Copy link
Collaborator

The Legion command always sends a screen capture the primary monitor to the TiRG DLL, regardless of what monitor your invoking the grid on (e.g. saying "Legion 2").

@chilimangoes chilimangoes self-assigned this Oct 29, 2015
@chilimangoes
Copy link
Collaborator Author

This turned out not to be a simple fix due to a limitation in the PIL ImageGrab.grab() functionality, which cannot grab outside the primary monitor (see related issue on PIL repo). I proposed a fix on that issue, but it requires modifying the C library PIL depends on, so it's not a simple python patch. I've got some python/ctypes code that I wrote to troubleshoot and test my proposed PIL fixes. I'm going to clean that up and add it to a replacement for grab() that we can use.

@synkarius
Copy link
Collaborator

Hmm. Good find, about PIL. And I'm very much in favor of replacing grab. It's the only thing PIL is really required for. Actually, PIL's role in relation to Rainbow Grid is really just cosmetic, so if we can remove it from Legion, we can remove it completely.

synkarius added a commit that referenced this issue Nov 21, 2015
Fixes #116 - Multimonitor support for Legion grid
@chilimangoes
Copy link
Collaborator Author

OK, I'll keep that in mind as I'm working on other grid improvements.

@LexiconCode LexiconCode added the Bug Unexpected behavior from existing features. label Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected behavior from existing features.
Projects
None yet
Development

No branches or pull requests

3 participants