Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: og type for video #454

Closed
wants to merge 1 commit into from
Closed

feat: og type for video #454

wants to merge 1 commit into from

Conversation

thereis
Copy link
Contributor

@thereis thereis commented Aug 30, 2023

Description

This PR will add the missing og:type for videos.

OG Docs Reference

@github-actions github-actions bot added this to the 3.7.1 milestone Aug 30, 2023
@thereis
Copy link
Contributor Author

thereis commented Sep 6, 2023

any chance of this being merged @diced?

TacticalTechJay
TacticalTechJay approved these changes Sep 9, 2023
View reviewed changes
Copy link
Collaborator

@TacticalTechJay TacticalTechJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem breaking. So, LGTM!

@TacticalTechJay
Copy link
Collaborator

Ah, seems like you didn't have your commit signed. Won't be able to merge unless you have 'em signed.

@thereis thereis closed this Sep 9, 2023
@thereis thereis deleted the feat/og-type-video-other branch September 9, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TacticalTechJay TacticalTechJay TacticalTechJay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thereis @TacticalTechJay