Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment Initialization failure handling #453

Merged
merged 12 commits into from
Jun 7, 2024
Merged

Experiment Initialization failure handling #453

merged 12 commits into from
Jun 7, 2024

Conversation

arjanoop
Copy link
Contributor

Experiment Initialization failure handling

Resolves: Issue 420

@arjanoop arjanoop requested a review from MichaelRoeder May 31, 2024 08:03
MichaelRoeder
MichaelRoeder requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@MichaelRoeder MichaelRoeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is not good practice to return JSON as content type if the message actually does not contain JSON. Please look at the comments in the code for more details.

src/main/java/org/aksw/gerbil/exceptions/FaultyConfigurationException.java Show resolved Hide resolved
src/main/java/org/aksw/gerbil/web/MainController.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/gerbil/web/MainController.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/gerbil/web/MainController.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/gerbil/web/MainController.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/gerbil/web/MainController.java Outdated Show resolved Hide resolved
src/main/java/org/aksw/gerbil/web/response/execution/ExperimentExecutionResponse.java Show resolved Hide resolved
@arjanoop arjanoop requested a review from MichaelRoeder June 6, 2024 10:50
MichaelRoeder
MichaelRoeder requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@MichaelRoeder MichaelRoeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think text/plain would be the better media type when returning the plain experiment ID.

@arjanoop arjanoop requested a review from MichaelRoeder June 7, 2024 10:39
MichaelRoeder
MichaelRoeder approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@MichaelRoeder MichaelRoeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelRoeder MichaelRoeder merged commit e20b21d into master Jun 7, 2024
4 checks passed
@MichaelRoeder MichaelRoeder deleted the dev/arjanoop/420_experiment_failure_handling branch June 7, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelRoeder MichaelRoeder MichaelRoeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GERBIL aborts the start of an experiment without informing the user
2 participants
@arjanoop @MichaelRoeder