Device sync improvements #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR solves issue #18 |
|
@hildensia not to push you, but do you have time to review this pr? |
hildensia
approved these changes
Jan 25, 2022
| @@ -50,6 +51,12 @@ async def sender_task(self): | |||
| await self.sync_scenes(0) | |||
| await self.get_device_names() | |||
|
|
|||
| logging.info("Waiting until all devices are retreived") | |||
| await trio.sleep(5) | |||
There was a problem hiding this comment.
why 5s? Could we react to the actual event somehow?
There was a problem hiding this comment.
The problem faced here is that it is not known how many devices will be returned. So we can wait for the first device name to return, but then we still don't know how much devices will show up. The best thing to do imo, is to rerun this sync some times more often, but it is not necessary to do this every 30 seconds. It takes some time to implement that. Is it ok that this becomes an issue and it is resolved later?
|
Only minor things. Can you run the |
PEB8
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way devices are synced. It has got a reverse engineered device sync implementation from the original app. It does this by using the DEVICE_NAME_REPLY, grabbing the ID of the device and send it back with a bogus device state. This will trigger DEVICE_STATUS_UPDATE to be sent to ELRO Connects. With this, ELRO Connects will get all the devices and their statuses within ~40 seconds after launch.
The protocol documentation has also been updated.