-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changes to the devices/hub through MQTT #20
Conversation
This looks amazing. The only thing we wouldn't be able to do which is possible in the app is removing/replacing a device. When enabling a test alarm can it then also be disabled through the hub like a normal alarm? |
Replacing and/or removing can be done (i think), but i did not want to make this change to big. I was planning on implementing after this PR was approved. I do not know about a real alarm, but as far as i know when you send a test alarm to your device with the app, you cannot silence the device. You can only silence the hub. The implementation of this PR is equal to that. I have seen that the state of a device can be changed, but i did not take a deep dive into that, also because i could not really find that in the app. The only state that is set by the app, is the test alarm state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Only had minor comments.
Sorry. I think that solution is fine. |
This update allows for changes to the hub or devices through MQTT, to facilitate that a few changes had to be made. There are also other improvements. These are all the changes in this PR
One thing that i could not do was to write a proper test for the handle_device_messages, because I do not know how to do that properly.
I believe the following issues are addresses (maybe partially)
#12
#18
#7