improve gamepad stash control, fix #7019 #7551
Conversation
There was a problem hiding this comment.
Nice to see some progress on that issue :D (especially since I've been too lazy to do anything like I said I would ages back...). The behaviour is a definite improvement compared to what we currently have.
As part of #6536 I added some code in PerformPrimaryAction (see https://github.com/Sophie452/devilutionX/blob/c641b49d73a547fcf953ed305936c9414d525f45/Source/controls/plrctrls.cpp#L1897-L1904) that shifts the cursor to the bottom right cell after pasting an item. That's no longer necessary with this PR, we want the cursor to stay in the centre of the item.
|
@Sophie452 nice work, if you have time to address the comments from @ephphatha I think this will be good to merge. You can ignore the failing PS4 build, it's a known issue with a required package. |
Sophie452
force-pushed
the
master
branch
2 times, most recently
from
0fee26d
to
1a49194
Compare
|
Thanks for your thorough review. I tried to correct all points. |
|
Also please run clag-format to make sure the changes conform to the style guide |
|
Sorry that you had to wait. The improvements have been completed and added the clang-format. Thanks for your help :) |
There was a problem hiding this comment.
Nice work, moving around the stash with a gamepad is much nicer now.
Testing this change has revealed an issue with the way we handle Stash to Inventory movement specifically, it ends up requiring moving right twice if the cursor moves onto a 2-wide item in the last two stash columns. This appears to be because we don't handle moving onto the inventory as aggressively as moving out of it. It's a more complicated fix than I'd want to include in this PR.
Should improve gamepad control in stash, see #7019
First time contribution, so be gentle :)