-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup panel code (Part 1) #7417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuripourre
approved these changes
Sep 15, 2024
AJenbo
reviewed
Sep 15, 2024
AJenbo
reviewed
Sep 15, 2024
need a rebase |
kphoenix137
force-pushed
the
cleanup-panel
branch
from
September 15, 2024 19:49
b0d4a31
to
424bb21
Compare
kphoenix137
force-pushed
the
cleanup-panel
branch
from
September 15, 2024 21:33
8cd8cc0
to
b4f1d5f
Compare
Also corrects belt rect
Includes level up button getting a rect
DrawLevelUpIcon()
AJenbo
reviewed
Sep 16, 2024
AJenbo
reviewed
Sep 16, 2024
AJenbo
previously approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good progress, eventually i hope we can have most of the sizes driven by the sprite sizes rather then hard coded values.
AJenbo
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
All of this should make it entirely easier to mod the control panel without having to play around with magic numbers in many functions.