Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stormshield #7070

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Fix Stormshield #7070

merged 1 commit into from
Apr 13, 2024

Conversation

kphoenix137
Copy link
Collaborator

This one may be a bit controversial. Based on: diasurgical/devilution#64 (comment)

By removing INVCURS from unique items, Stormshield now has a slot open that it didn't before.

In the PR demo, Stormshield had 50% lightning resistance with no set graphic. I was looking around other item data from the PR demo comparing it to retail to see what the "correct" lightning resist amount should be.

Here's what I found
In the PR demo all the unique item resistance values were identical to retail resistance values, with some notable exceptions:

  • Aguinara's Hatchet: 100% resist magic -> 80% resist magic
  • Schaefer's Hammer: 100% resist lightning -> 80% resist lightning
  • Inferno: 75% resist fire -> 80% resist fire
  • Constricting Ring: 100% resist all -> 75% resist all

It appears that previous resistances were capped at 100% in the PR demo, and the cap was likely revised to 80% and then 75%. All resistance items that were not at 75% or higher went untouched, leading me to believe that 50% lightning resist is the correct amount for Stormshield in retail.

@AJenbo AJenbo merged commit 36aca86 into diasurgical:master Apr 13, 2024
19 of 21 checks passed
@kphoenix137 kphoenix137 deleted the fix-stormshield branch April 13, 2024 22:04
@kphoenix137 kphoenix137 restored the fix-stormshield branch April 13, 2024 22:29
@kphoenix137 kphoenix137 deleted the fix-stormshield branch April 16, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants