-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally set cursor graphic for unique items #7067
Merged
AJenbo
merged 7 commits into
diasurgical:master
from
kphoenix137:revise-uicurs-handling
Apr 13, 2024
Merged
Conditionally set cursor graphic for unique items #7067
AJenbo
merged 7 commits into
diasurgical:master
from
kphoenix137:revise-uicurs-handling
Apr 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DakkJaniels
reviewed
Apr 11, 2024
kphoenix137
force-pushed
the
revise-uicurs-handling
branch
from
April 11, 2024 20:51
7bb98cb
to
ba0d4fa
Compare
qndel
reviewed
Apr 12, 2024
Wait, can't I just do what monstdat does for trn files and have empty fields instead which signal no iCurs change? |
that sound somewhat nicer, let me know when you figure out if you can |
ready |
AJenbo
previously approved these changes
Apr 13, 2024
AJenbo
reviewed
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ICURS_DEFAULT
, which when set for a unique item uses the base item's cursor graphic instead of setting its own.Required to deal with Gnarled Root, a unique that is able to appear on 2 base items, but does not have an
INVCURS
item power in vanilla.