-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary release #19
Comments
Yes, but things are changing a lot at the moment and we have a few short comings that we would like to take care of first. 64bit builds are currently not on feature parity with the 32bit builds so we are also debating if this should be included or not. |
I would love to have a binary release, as getting this built on Fedora has been a futile effort. I still am unable to get past getting cmake to create the makefile. |
@andrewschott do you get any errors? We have recently updated the CMake scripts to where it should work more automatic as long as you have installed the needed dependencies. |
Yep, here is the output of the cmake command:
|
@andrewschott Oh, that was fixed about 15 hours ago :) Since then we have also added basic UDP network support and the menu performance has been fixed. Let me know how it works out. |
Indeed you have! I did a quick check prior to departing for work, and the binary works great sofar! Thanks! |
Arh that is good to hear, 32bit SDL on 64bit is broken on Ubuntu 18.04 so I haven't had a chance to verify it on a 64bit platform yet. |
last week's build was compiling just fine for me on ubuntu, but right now I'm getting a missing libsodium message although I just installed it: -- cotire 1.8.0 loaded. -- Configuring incomplete, errors occurred! |
@sheepo99 thanks for reporting, the issue should now be solved. |
Hi Ajenbo, Just tried to recompile latest source. Issue persists. Error msg: -- cotire 1.8.0 loaded. -- Configuring incomplete, errors occurred! |
@sheepo99 it looks like you haven't installed libsodium-dev:i386 |
@AJenbo I have the latest version of libsodium-dev:i386 installed (just checked for both dev and non-dev libs), and the issue still persists. I am attaching the error log. For the record, I am running Xubuntu 18.04 bionic 64bit version. |
Could you try deleting everything in the build32 folder and use the following command: |
@AJenbo here are the logs after I tried that. Please note I added FORCE32=1 along with the trace and debug cmds. |
Also copypasting fragment of compile output: /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake(136): if(${_NAME}_FIND_REQUIRED ) Called from: [4] /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake |
FIXED IT! Turns out I had only installed libsodium-dev:i386 and I needed the amd64 version as well. I would advise to add it to the readme instructions. |
Thanks good to know :) |
Since there is not going to be a release for a bit, I feel like I should point out that the "Download Devilution" button under the "How To Play:" section of the readme is 404. |
Yeah I want to make a release . The release I have is so old though. |
There should be a release in about a week |
Single-player difficulty selection was implemented in a very hacky way. Documents what's going on there and fixes a memory leak. Memory leaks that this fixes looked like this: ``` Direct leak of 64 byte(s) in 1 object(s) allocated from: #0 0x7f435b789f17 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.6+0xb1f17) #1 0x5567766c62b8 in dvl::selgame_GameSelection_Select(int) ../SourceX/DiabloUI/selgame.cpp:163 #2 0x5567766d8ee8 in dvl::selhero_Load_Select(int) ../SourceX/DiabloUI/selhero.cpp:464 #3 0x5567766d6ed1 in dvl::selhero_List_Select(int) ../SourceX/DiabloUI/selhero.cpp:325 #4 0x556776692683 in dvl::UiFocusNavigationSelect() ../SourceX/DiabloUI/diabloui.cpp:396 #5 0x55677669158e in HandleMenuAction ../SourceX/DiabloUI/diabloui.cpp:223 #6 0x5567766917b9 in dvl::UiFocusNavigation(SDL_Event*) ../SourceX/DiabloUI/diabloui.cpp:277 #7 0x556776695dff in dvl::UiPollAndRender() ../SourceX/DiabloUI/diabloui.cpp:626 #8 0x5567766d94ef in UiSelHeroDialog ../SourceX/DiabloUI/selhero.cpp:512 diasurgical#9 0x5567766d997f in dvl::UiSelHeroSingDialog(int (*)(int (*)(dvl::_uiheroinfo*)), int (*)(dvl::_uiheroinfo*), int (*)(dvl::_uiheroinfo*), void (*)(unsigned int, dvl::_uidefaultstats*), int*, char (*) [16], int*) ../SourceX/DiabloUI/selhero.cpp:547 diasurgical#10 0x556776a44f45 in mainmenu_select_hero_dialog ../Source/mainmenu.cpp:98 diasurgical#11 0x5567765f9f15 in SNetInitializeProvider ../SourceX/storm/storm_net.cpp:102 diasurgical#12 0x556776c996b9 in multi_init_single ../Source/multi.cpp:826 diasurgical#13 0x556776c98b1e in NetInit ../Source/multi.cpp:770 diasurgical#14 0x5567767d0c0b in StartGame ../Source/diablo.cpp:375 diasurgical#15 0x556776a4493d in mainmenu_init_menu ../Source/mainmenu.cpp:45 diasurgical#16 0x556776a44c05 in mainmenu_single_player ../Source/mainmenu.cpp:61 diasurgical#17 0x556776a454a9 in mainmenu_loop ../Source/mainmenu.cpp:152 diasurgical#18 0x5567767d2892 in DiabloMain ../Source/diablo.cpp:602 diasurgical#19 0x5567766e3c69 in main ../SourceX/main.cpp:34 diasurgical#20 0x7f435a69ecb1 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x28cb1) ```
Single-player difficulty selection was implemented in a very hacky way. Documents what's going on there and fixes a memory leak. Memory leaks that this fixes looked like this: ``` Direct leak of 64 byte(s) in 1 object(s) allocated from: #0 0x7f435b789f17 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.6+0xb1f17) #1 0x5567766c62b8 in dvl::selgame_GameSelection_Select(int) ../SourceX/DiabloUI/selgame.cpp:163 #2 0x5567766d8ee8 in dvl::selhero_Load_Select(int) ../SourceX/DiabloUI/selhero.cpp:464 #3 0x5567766d6ed1 in dvl::selhero_List_Select(int) ../SourceX/DiabloUI/selhero.cpp:325 #4 0x556776692683 in dvl::UiFocusNavigationSelect() ../SourceX/DiabloUI/diabloui.cpp:396 #5 0x55677669158e in HandleMenuAction ../SourceX/DiabloUI/diabloui.cpp:223 #6 0x5567766917b9 in dvl::UiFocusNavigation(SDL_Event*) ../SourceX/DiabloUI/diabloui.cpp:277 #7 0x556776695dff in dvl::UiPollAndRender() ../SourceX/DiabloUI/diabloui.cpp:626 #8 0x5567766d94ef in UiSelHeroDialog ../SourceX/DiabloUI/selhero.cpp:512 #9 0x5567766d997f in dvl::UiSelHeroSingDialog(int (*)(int (*)(dvl::_uiheroinfo*)), int (*)(dvl::_uiheroinfo*), int (*)(dvl::_uiheroinfo*), void (*)(unsigned int, dvl::_uidefaultstats*), int*, char (*) [16], int*) ../SourceX/DiabloUI/selhero.cpp:547 #10 0x556776a44f45 in mainmenu_select_hero_dialog ../Source/mainmenu.cpp:98 #11 0x5567765f9f15 in SNetInitializeProvider ../SourceX/storm/storm_net.cpp:102 #12 0x556776c996b9 in multi_init_single ../Source/multi.cpp:826 #13 0x556776c98b1e in NetInit ../Source/multi.cpp:770 #14 0x5567767d0c0b in StartGame ../Source/diablo.cpp:375 #15 0x556776a4493d in mainmenu_init_menu ../Source/mainmenu.cpp:45 #16 0x556776a44c05 in mainmenu_single_player ../Source/mainmenu.cpp:61 #17 0x556776a454a9 in mainmenu_loop ../Source/mainmenu.cpp:152 #18 0x5567767d2892 in DiabloMain ../Source/diablo.cpp:602 #19 0x5567766e3c69 in main ../SourceX/main.cpp:34 #20 0x7f435a69ecb1 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x28cb1) ```
I see the parent project had a 0.5 release, will there be any binary releases of this project for the people who can't/won't compile?
The text was updated successfully, but these errors were encountered: