Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary release #19

Closed
predator8bit opened this issue Jan 31, 2019 · 21 comments
Closed

Binary release #19

predator8bit opened this issue Jan 31, 2019 · 21 comments

Comments

@predator8bit
Copy link

I see the parent project had a 0.5 release, will there be any binary releases of this project for the people who can't/won't compile?

@AJenbo
Copy link
Member

AJenbo commented Jan 31, 2019

Yes, but things are changing a lot at the moment and we have a few short comings that we would like to take care of first.

64bit builds are currently not on feature parity with the 32bit builds so we are also debating if this should be included or not.

@andrewschott
Copy link

I would love to have a binary release, as getting this built on Fedora has been a futile effort. I still am unable to get past getting cmake to create the makefile.

@AJenbo
Copy link
Member

AJenbo commented Jan 31, 2019

@andrewschott do you get any errors? We have recently updated the CMake scripts to where it should work more automatic as long as you have installed the needed dependencies.

@andrewschott
Copy link

Yep, here is the output of the cmake command:

[andrew@schotty-tower-wireless build32]$ FORCE32=1 cmake ..
-- cotire 1.8.0 loaded.
-- Using 32-bit toolchain
-- Configuring done
CMake Error at CMakeLists.txt:193 (add_executable):
  Cannot find source file:

    Stub/DiabloUI/selconn.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx


CMake Error at CMakeLists.txt:193 (add_executable):
  No SOURCES given to target: devilution


-- Build files have been written to: /home/andrew/workspace/devilutionx/devilutionX/build32
[andrew@schotty-tower-wireless build32]$ 

@AJenbo
Copy link
Member

AJenbo commented Feb 1, 2019

@andrewschott Oh, that was fixed about 15 hours ago :) Since then we have also added basic UDP network support and the menu performance has been fixed. Let me know how it works out.

@andrewschott
Copy link

andrewschott commented Feb 1, 2019

@andrewschott Oh, that was fixed about 15 hours ago :) Since then we have also added basic UDP network support and the menu performance has been fixed. Let me know how it works out.

Indeed you have!

I did a quick check prior to departing for work, and the binary works great sofar! Thanks!

@AJenbo
Copy link
Member

AJenbo commented Feb 1, 2019

Arh that is good to hear, 32bit SDL on 64bit is broken on Ubuntu 18.04 so I haven't had a chance to verify it on a 64bit platform yet.

@sheepo99
Copy link

sheepo99 commented Feb 2, 2019

last week's build was compiling just fine for me on ubuntu, but right now I'm getting a missing libsodium message although I just installed it:

-- cotire 1.8.0 loaded.
-- Using 32-bit toolchain
-- Using 32-bit libraries from /usr/lib/i386-linux-gnu
CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find sodium (missing: sodium_LIBRARY_RELEASE
sodium_LIBRARY_DEBUG)
Call Stack (most recent call first):
/usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
CMake/Findsodium.cmake:227 (find_package_handle_standard_args)
CMakeLists.txt:48 (find_package)

-- Configuring incomplete, errors occurred!
See also "/home/jvitorino/devilutionX-master/build32/CMakeFiles/CMakeOutput.log".
See also "/home/jvitorino/devilutionX-master/build32/CMakeFiles/CMakeError.log".

@AJenbo
Copy link
Member

AJenbo commented Feb 2, 2019

@sheepo99 thanks for reporting, the issue should now be solved.

@sheepo99
Copy link

sheepo99 commented Feb 2, 2019

Hi Ajenbo,

Just tried to recompile latest source. Issue persists. Error msg:

-- cotire 1.8.0 loaded.
-- Using 32-bit toolchain
-- Using 32-bit libraries from /usr/lib/i386-linux-gnu
-- The C compiler identification is GNU 7.3.0
-- The CXX compiler identification is GNU 7.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found SDL2: /usr/lib/i386-linux-gnu/libSDL2main.a;/usr/lib/i386-linux-gnu/libSDL2.so;-lpthread
-- Found SDL2_ttf: /usr/lib/i386-linux-gnu/libSDL2_ttf.so (found version "2.0.14")
-- Found SDL2_mixer: /usr/lib/i386-linux-gnu/libSDL2_mixer.so (found version "2.0.2")
CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find sodium (missing: sodium_LIBRARY_RELEASE
sodium_LIBRARY_DEBUG)
Call Stack (most recent call first):
/usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
CMake/Findsodium.cmake:227 (find_package_handle_standard_args)
CMakeLists.txt:48 (find_package)

-- Configuring incomplete, errors occurred!
See also "/home/jvitorino/Desktop/devilutionX-master/build32/CMakeFiles/CMakeOutput.log".
See also "/home/jvitorino/Desktop/devilutionX-master/build32/CMakeFiles/CMakeError.log".

@AJenbo
Copy link
Member

AJenbo commented Feb 3, 2019

@sheepo99 it looks like you haven't installed libsodium-dev:i386

@sheepo99
Copy link

sheepo99 commented Feb 3, 2019

@AJenbo I have the latest version of libsodium-dev:i386 installed (just checked for both dev and non-dev libs), and the issue still persists. I am attaching the error log.

For the record, I am running Xubuntu 18.04 bionic 64bit version.

CMakeError.log

@AJenbo
Copy link
Member

AJenbo commented Feb 4, 2019

Could you try deleting everything in the build32 folder and use the following command:
cmake .. --trace --debug-output

@sheepo99
Copy link

sheepo99 commented Feb 4, 2019

@AJenbo here are the logs after I tried that. Please note I added FORCE32=1 along with the trace and debug cmds.

CMakeError.log
CMakeOutput.log

@sheepo99
Copy link

sheepo99 commented Feb 4, 2019

Also copypasting fragment of compile output:

/usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake(136): if(${_NAME}_FIND_REQUIRED )
Called from: [4] /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake
[3] /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake
[2] /home/jvitorino/Desktop/devilutionX-master/CMake/Findsodium.cmake
[1] /home/jvitorino/Desktop/devilutionX-master/CMakeLists.txt
/usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake(137): message(FATAL_ERROR Could NOT find sodium (missing: sodium_LIBRARY_RELEASE sodium_LIBRARY_DEBUG) )
Called from: [4] /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake
[3] /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake
[2] /home/jvitorino/Desktop/devilutionX-master/CMake/Findsodium.cmake
[1] /home/jvitorino/Desktop/devilutionX-master/CMakeLists.txt
CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find sodium (missing: sodium_LIBRARY_RELEASE
sodium_LIBRARY_DEBUG)
Call Stack (most recent call first):
/usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
CMake/Findsodium.cmake:227 (find_package_handle_standard_args)
CMakeLists.txt:48 (find_package)

Called from: [4] /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake
[3] /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake
[2] /home/jvitorino/Desktop/devilutionX-master/CMake/Findsodium.cmake
[1] /home/jvitorino/Desktop/devilutionX-master/CMakeLists.txt
-- Configuring incomplete, errors occurred!
See also "/home/jvitorino/Desktop/devilutionX-master/build32/CMakeFiles/CMakeOutput.log".
See also "/home/jvitorino/Desktop/devilutionX-master/build32/CMakeFiles/CMakeError.log".

@sheepo99
Copy link

sheepo99 commented Feb 4, 2019

FIXED IT! Turns out I had only installed libsodium-dev:i386 and I needed the amd64 version as well. I would advise to add it to the readme instructions.

@AJenbo
Copy link
Member

AJenbo commented Feb 4, 2019

Thanks good to know :)

@predator8bit
Copy link
Author

Since there is not going to be a release for a bit, I feel like I should point out that the "Download Devilution" button under the "How To Play:" section of the readme is 404.

@ghost
Copy link

ghost commented Feb 15, 2019

Yeah I want to make a release . The release I have is so old though.

@AJenbo
Copy link
Member

AJenbo commented Feb 15, 2019

There should be a release in about a week

@AJenbo
Copy link
Member

AJenbo commented Feb 27, 2019

@AJenbo AJenbo closed this as completed Feb 27, 2019
AJenbo pushed a commit that referenced this issue Sep 26, 2019
glebm added a commit to glebm/devilutionX that referenced this issue Mar 23, 2021
Single-player difficulty selection was implemented in a very hacky way.

Documents what's going on there and fixes a memory leak.

Memory leaks that this fixes looked like this:

```
Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x7f435b789f17 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.6+0xb1f17)
    #1 0x5567766c62b8 in dvl::selgame_GameSelection_Select(int) ../SourceX/DiabloUI/selgame.cpp:163
    #2 0x5567766d8ee8 in dvl::selhero_Load_Select(int) ../SourceX/DiabloUI/selhero.cpp:464
    #3 0x5567766d6ed1 in dvl::selhero_List_Select(int) ../SourceX/DiabloUI/selhero.cpp:325
    #4 0x556776692683 in dvl::UiFocusNavigationSelect() ../SourceX/DiabloUI/diabloui.cpp:396
    #5 0x55677669158e in HandleMenuAction ../SourceX/DiabloUI/diabloui.cpp:223
    #6 0x5567766917b9 in dvl::UiFocusNavigation(SDL_Event*) ../SourceX/DiabloUI/diabloui.cpp:277
    #7 0x556776695dff in dvl::UiPollAndRender() ../SourceX/DiabloUI/diabloui.cpp:626
    #8 0x5567766d94ef in UiSelHeroDialog ../SourceX/DiabloUI/selhero.cpp:512
    diasurgical#9 0x5567766d997f in dvl::UiSelHeroSingDialog(int (*)(int (*)(dvl::_uiheroinfo*)), int (*)(dvl::_uiheroinfo*), int (*)(dvl::_uiheroinfo*), void (*)(unsigned int, dvl::_uidefaultstats*), int*, char (*) [16], int*) ../SourceX/DiabloUI/selhero.cpp:547
    diasurgical#10 0x556776a44f45 in mainmenu_select_hero_dialog ../Source/mainmenu.cpp:98
    diasurgical#11 0x5567765f9f15 in SNetInitializeProvider ../SourceX/storm/storm_net.cpp:102
    diasurgical#12 0x556776c996b9 in multi_init_single ../Source/multi.cpp:826
    diasurgical#13 0x556776c98b1e in NetInit ../Source/multi.cpp:770
    diasurgical#14 0x5567767d0c0b in StartGame ../Source/diablo.cpp:375
    diasurgical#15 0x556776a4493d in mainmenu_init_menu ../Source/mainmenu.cpp:45
    diasurgical#16 0x556776a44c05 in mainmenu_single_player ../Source/mainmenu.cpp:61
    diasurgical#17 0x556776a454a9 in mainmenu_loop ../Source/mainmenu.cpp:152
    diasurgical#18 0x5567767d2892 in DiabloMain ../Source/diablo.cpp:602
    diasurgical#19 0x5567766e3c69 in main ../SourceX/main.cpp:34
    diasurgical#20 0x7f435a69ecb1 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x28cb1)
```
AJenbo pushed a commit that referenced this issue Mar 23, 2021
Single-player difficulty selection was implemented in a very hacky way.

Documents what's going on there and fixes a memory leak.

Memory leaks that this fixes looked like this:

```
Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x7f435b789f17 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.6+0xb1f17)
    #1 0x5567766c62b8 in dvl::selgame_GameSelection_Select(int) ../SourceX/DiabloUI/selgame.cpp:163
    #2 0x5567766d8ee8 in dvl::selhero_Load_Select(int) ../SourceX/DiabloUI/selhero.cpp:464
    #3 0x5567766d6ed1 in dvl::selhero_List_Select(int) ../SourceX/DiabloUI/selhero.cpp:325
    #4 0x556776692683 in dvl::UiFocusNavigationSelect() ../SourceX/DiabloUI/diabloui.cpp:396
    #5 0x55677669158e in HandleMenuAction ../SourceX/DiabloUI/diabloui.cpp:223
    #6 0x5567766917b9 in dvl::UiFocusNavigation(SDL_Event*) ../SourceX/DiabloUI/diabloui.cpp:277
    #7 0x556776695dff in dvl::UiPollAndRender() ../SourceX/DiabloUI/diabloui.cpp:626
    #8 0x5567766d94ef in UiSelHeroDialog ../SourceX/DiabloUI/selhero.cpp:512
    #9 0x5567766d997f in dvl::UiSelHeroSingDialog(int (*)(int (*)(dvl::_uiheroinfo*)), int (*)(dvl::_uiheroinfo*), int (*)(dvl::_uiheroinfo*), void (*)(unsigned int, dvl::_uidefaultstats*), int*, char (*) [16], int*) ../SourceX/DiabloUI/selhero.cpp:547
    #10 0x556776a44f45 in mainmenu_select_hero_dialog ../Source/mainmenu.cpp:98
    #11 0x5567765f9f15 in SNetInitializeProvider ../SourceX/storm/storm_net.cpp:102
    #12 0x556776c996b9 in multi_init_single ../Source/multi.cpp:826
    #13 0x556776c98b1e in NetInit ../Source/multi.cpp:770
    #14 0x5567767d0c0b in StartGame ../Source/diablo.cpp:375
    #15 0x556776a4493d in mainmenu_init_menu ../Source/mainmenu.cpp:45
    #16 0x556776a44c05 in mainmenu_single_player ../Source/mainmenu.cpp:61
    #17 0x556776a454a9 in mainmenu_loop ../Source/mainmenu.cpp:152
    #18 0x5567767d2892 in DiabloMain ../Source/diablo.cpp:602
    #19 0x5567766e3c69 in main ../SourceX/main.cpp:34
    #20 0x7f435a69ecb1 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x28cb1)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants