Compile mpqapi.cpp as C

[AJenbo]

Bin exactness of the file is not affected.

[mewmew]

Does the C compiler have const?

[AJenbo]

Yes const can be applied to variables.

[squidcc]

Not sure why you're removing all the consts since they have no bearing on C++ -> C, plus it does break binary exactness.

pfile_encode_hero() calls mpqapi_write_file() with a literal constant string "hero", by removing the const specifier from the function definition that string can't be passed as a pointer to .rdata (which is what the original code does).

[mewmew]

pfile_encode_hero() calls mpqapi_write_file() with a literal constant string "hero", by removing the const specifier from the function definition that string can't be passed as a pointer to .rdata (which is what the original code does).

That's a good point. DIdn't know exactly how the compiler decides which segment to put string literal in.

[mewmew]

@AJenbo would mpqapi.cpp also compile with the consts? If so, lets keep them. Was there any other issues that prevent us from compiling this file with /Tc?

[AJenbo]

As described in #528; compiling mpqapi.cpp as C was causing the compiler to emit some errors. Looking at it I found that the issue was introduced in this commit e2adda1 where the const where added, reverting the const resolved the build issue. Looking closer at the issue now I noticed that it's because the header file was not correctly updated when they where added. I have changed this PR to fix this issue instead.

[mewmew]

As described in #528; compiling mpqapi.cpp as C was causing the compiler to emit some errors. Looking at it I found that the issue was introduced in this commit e2adda1 where the const where added, reverting the const resolved the build issue. Looking closer at the issue now I noticed that it's because the header file was not correctly updated when they where added. I have changed this PR to fix this issue instead.

Ah, that makes sense. Thanks!

[mewmew]

LGTM.