Undostack: Fix segfault when trying to fetch macro on -1 index #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if user adds a command to the undostack, and then undos it, and then adds another command - this causes a segfault while fetching macro ID from command on current undoPos. Current undo position pointer of undostack is being moved to -1 if user undos every possible command on the stack. Everytime user adds a new command, eraseRedundantCmds() method is being called, because all commands that are in "undo" state need to be cleared. So the solution to that is to simply clear every single macro and command while erasing redundant commands, if the current undo position is -1 - this basically means that every single command/macro is in undo state, so we clear all of them.
As a reproduction with and without this patch: