Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated image branding (issue #4444) #4702

Merged
merged 3 commits into from
Feb 9, 2014
Merged

Conversation

goobertron
Copy link

Have created new logos, in lower case Roboto, and changed one file (an emailer) which referred to logo_caps.png. This addresses #4444.

Most of these appear unused in the code. The only two I could find being used were logo_caps.png (now logo_small.png) and powered_by_diaspora.png, which appears in the footer of the desktop version.

I'm wondering whether powered_by_diaspora in the footer wouldn't be better as text rather than an image. The image is so small that it's not easy to read. If we presented it as text in light grey, it would probably look better and also scale better.

But do we even need 'powered by diaspora*' there?

@goobertron
Copy link
Author

logo_white4x.png is one which I may use in a redesigned default.html

@Ruxton
Copy link
Contributor

Ruxton commented Jan 19, 2014

For some reason in all the graphics the letter d and i are sitting a pixel or 2 higher than "aspora"

Also, I think the edges of these new ones are far to hard/sharp.

@goobertron
Copy link
Author

Hi Ruxton, thanks for your comments. Point 1, that's very odd. It shouldn't be the case as they were typed on a line. I wonder whether it's a Roboto thing, the d and i not coming quite as low on the line as the other letters in the word?

Point 2, I agree. I was unable to find a way to soften the edges without including a background into the image so there is some blending of the edges. The smallest images particularly suffer from this. In the end I did include a background with powered_by_diaspora.png because it looked awful otherwise.

It may need either a rethink on how logos are presented in the app, or someone with greater skills with graphics than I!

Just a thought: now that Roboto is included in the diaspora installation, do we actually need to provide graphics for the word 'diaspora*' at all? Could we use text instead of images?

@goobertron
Copy link
Author

One thing I can do is to blur the edges of the type before rasterising. This helps, but still doesn't look great, in my opinion.

@jaywink
Copy link
Contributor

jaywink commented Jan 19, 2014

Can anyone think of downsides of not using images at all for branding that is strictly based on a font? I cannot, except maybe for older browsers - but we pretty much don't support old browsers :)

@jhass
Copy link
Member

jhass commented Feb 9, 2014

I'll merge this for now, thank you @goobertron! We can always further reduce the image usage at some later point.

jhass added a commit that referenced this pull request Feb 9, 2014
@jhass jhass merged commit 19c9c0f into diaspora:develop Feb 9, 2014
@jhass jhass added this to the next milestone Feb 9, 2014
@goobertron goobertron deleted the new_logos branch February 9, 2014 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants