Issue #4124 Check write access before authorizing Twitter

[oliverbarnes]

No description provided.

[oliverbarnes]

Looks like the build is failing due to tests that were already broken

[svbergerem]

You changed a lot of language files. Afaik you should change config/locales/diaspora/en.yml and must not change any other language file. All other languages will be done via webtranslateit. @MrZyx is that right?

[jhass]

@svbergerem is right, please only ever edit en.yml.

[jhass]

And the failures indicate that you introduced an endless recursion somewhere.

[jhass]

The guard gem already pulls in pry as a dependency, so you can just require and use it.

[oliverbarnes]

Ok, just committed the fixes for the issues pointed out. Sorry about the locale files, I thought I was being thorough :) Should I revert that?

[jhass]

Yes, please only edit the *en.yml variants.

[jhass]

Okay, this is looking really good now, please just revert the changes to db/schema.rb, add a changelog entry and squash the commits together:

git checkout 4124-check-twitter-write-access-before-auth
git checkout develop db/schema.rb
$EDITOR Changelog.md
git commit -m "revert db/schema.rb changes and added changelog entry" db/schema.rb Changelog.md
git rebase -i develop
# Leave the first line at pick, choose squash, or s in short, for all other lines
git push -f origin 4124-check-twitter-write-access-before-auth

[oliverbarnes]

Done, thanks for the walk-through

[jhass]

Thank you!