Remove non-portable bashisms from most of the scripts. ++ #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only install.sh has any bashisms left. However, the bug which prevented it from running on most systems (using /bin/bash directly) has been fixed.
While here avoid bashisms in the first place.
|
anyone wanna give this a try, |
|
Maybe posting this in Diaspora reach more testers with Mac or BSD. And know how easy it is to install diaspora :] |
|
I've now tested the install script on a FreeBSD installation, where I was able to spot a small boo boo (that I fixed right away). |
jhass
added a commit
that referenced
this pull request
Nov 10, 2012
Remove non-portable bashisms from most of the scripts. ++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this contains #3673 plus my own improvements to the install output/logging code.
don't pull yet, still needs testing...
thanks @grimreaper