upgrade docker version and go #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhui what do you think? |
dhui
reviewed
Jun 28, 2024
There was a problem hiding this comment.
@samlawson355 thanks for the PR!
We've migrated to GitHub Actions but have kept the old TravisCI and CircleCI configs around to make reverts (or multi-vendor CI runs) easier
awesome! thank you @dhui! i have reverted that file 😄 |
dhui
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Sorry for the delay and thanks for your patience @samlawson355 ! I'm going to go ahead and merge your PR and make any necessary fixes/changes
| @@ -11,7 +11,7 @@ const ( | |||
| ) | |||
|
|
|||
| func init() { | |||
| rand.Seed(time.Now().UnixNano()) | |||
| rand.New(rand.NewSource(time.Now().UnixNano())) // nolint:gosec | |||
There was a problem hiding this comment.
I'll change this to use math/rand/v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade docker version and bump go version
docker upgrade to 26.1.3+incompatible broke dktest 🙁