Default version for custom builds + check for eye log existence

dhruvaray · Aug 28, 2013 · ef4de3d · ef4de3d
1 parent 3f08353
commit ef4de3d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/extension/chrome/content/spa_eye/hooks/bb/bbhook.js b/extension/chrome/content/spa_eye/hooks/bb/bbhook.js
@@ -357,7 +357,8 @@ define([
 
             logError:function (e) {
                 this._errors.push(e);
-                Events.dispatch([this.context.getPanel("spa_eye:logs")], 'onIntrospectionError', [e]);
+                var eye_logs = this.context.getPanel("spa_eye:logs");
+                eye_logs && Events.dispatch([eye_logs], 'onIntrospectionError', [e]);
                 if (FBTrace.DBG_SPA_EYE) {
                     FBTrace.sysout("spa_eye; Unexpected error", e);
                 }

diff --git a/extension/chrome/content/spa_eye/util/common.js b/extension/chrome/content/spa_eye/util/common.js
@@ -1,6 +1,7 @@
 define([
-    "firebug/lib/http"
-], function (Http) {
+    "firebug/lib/http",
+    "firebug/lib/locale"
+], function (Http, Locale) {
     return {
         Operation:{
             SAVE:"save", FETCH:"fetch", SET:"set", UNSET:"unset", CLEAR:"clear", RENDER:"render", ADD:"add",
@@ -16,7 +17,7 @@ define([
             Model:"Model", View:"View", Collection:"Collection"
         },
         getVersion:function (versionURL) {
-            var version = '';
+            var version = Locale.$STR("spa_eye.version.custom");
             var content = Http.getResource(versionURL);
             if (content) {
                 var m = /VERSION=(.*)/.exec(content);

diff --git a/extension/chrome/locale/en-US/spa_eye.properties b/extension/chrome/locale/en-US/spa_eye.properties
@@ -1,6 +1,7 @@
 spa_eye.title=Backbone Eye
 spa_eye.about=Backbone Eye $VERSION$
 spa_eye.tooltip=Inspect your Backbone application
+spa_eye.version.custom = [custom build]
 
 spa_eye.all=All
 spa_eye.loading=Loading...