Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable verify email button #1454

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

Chisomchima
Copy link
Member

@Chisomchima Chisomchima commented Dec 11, 2024

this PR attempts to fix this comment for the verify email button ticket

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Dec 11, 2024

🚀 Deployed on https://pr-1454--dhis2-user-profile.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify December 11, 2024 13:58 Inactive
@Chisomchima Chisomchima requested a review from tomzemp December 11, 2024 14:04
@dhis2-bot dhis2-bot temporarily deployed to netlify December 11, 2024 14:04 Inactive
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we should use consistent RegEx

src/layout/VerifyEmail.component.js Outdated Show resolved Hide resolved
@dhis2-bot dhis2-bot temporarily deployed to netlify December 12, 2024 10:32 Inactive
@Chisomchima Chisomchima requested a review from tomzemp December 12, 2024 10:32
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

@Chisomchima Chisomchima merged commit 4006555 into master Dec 13, 2024
6 checks passed
@Chisomchima Chisomchima deleted the DHIS2-18374/verify-email-button branch December 13, 2024 12:12
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants