Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only show pats that you created #1319

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Conversation

netroms
Copy link
Contributor

@netroms netroms commented Jun 22, 2023

Summary

Adds an API query filter on "createdBy" the current user's ID to show only personal access tokens created by the current user.
Without this filter, a user with "ALL" access would see everyone's tokens (not the actual token key, since that is hashed and not shown/ignored in the JSON response)

JIRA: DHIS2-15470

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 22, 2023

🚀 Deployed on https://pr-1319--dhis2-user-profile.netlify.app

@netroms netroms marked this pull request as ready for review June 26, 2023 07:07
@tomzemp tomzemp merged commit 37b723a into master Jun 27, 2023
@tomzemp tomzemp deleted the feat_show_only_owning_pats branch June 27, 2023 08:35
dhis2-bot added a commit that referenced this pull request Jun 27, 2023
# [30.4.0](v30.3.45...v30.4.0) (2023-06-27)

### Features

* only show pats that you created ([#1319](#1319)) ([37b723a](37b723a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 30.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

netroms added a commit that referenced this pull request Jun 27, 2023
netroms added a commit that referenced this pull request Jun 27, 2023
netroms added a commit that referenced this pull request Jun 27, 2023
netroms added a commit that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants