fix: prevent browser autofill on password fields

dhis2 · Nov 14, 2019 · 71736ac · 71736ac
2 parents 2394732 + 5832113
commit 71736ac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/account/AccountEditor.component.js b/src/account/AccountEditor.component.js
@@ -86,6 +86,7 @@ class AccountEditor extends Component {
                     floatingLabelText: this.context.d2.i18n.getTranslation('old_password'),
                     style: { width: '100%' },
                     changeEvent: 'onBlur',
+                    autoComplete: 'new-password',
                 },
                 validators: [{
                     validator: this.isNotEmpty,
@@ -101,6 +102,7 @@ class AccountEditor extends Component {
                     floatingLabelText: this.context.d2.i18n.getTranslation('new_password'),
                     style: { width: '100%' },
                     changeEvent: 'onBlur',
+                    autoComplete: 'new-password',
                 },
                 validators: [{
                     validator: isValidPassword,
@@ -116,6 +118,7 @@ class AccountEditor extends Component {
                     floatingLabelText: this.context.d2.i18n.getTranslation('repeat_new_password'),
                     style: { width: '100%' },
                     changeEvent: 'onBlur',
+                    autoComplete: 'new-password',
                 },
                 validators: [{
                     validator: this.isSamePassword,

diff --git a/src/layout/FormFields.component.js b/src/layout/FormFields.component.js
@@ -301,7 +301,9 @@ class FormFields extends Component {
         return (
             <div className="content-area">
                 <div style={styles.header}>{this.props.pageLabel}</div>
-                {this.renderFields(this.props.fieldKeys)}
+                <form autoComplete="off">
+                    {this.renderFields(this.props.fieldKeys)}
+                </form>
             </div>
         );
     }