Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sharing-dialog): add 'route' to SharingType type #1617

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

kabaros
Copy link
Collaborator

@kabaros kabaros commented Oct 8, 2024

route also is supported by sharing API, and currently gives a type error.

@kabaros kabaros requested a review from a team as a code owner October 8, 2024 20:15
@kabaros kabaros requested a review from Birkbjo October 8, 2024 20:16
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1617--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify October 8, 2024 20:19 Inactive
@kabaros kabaros merged commit 1d9664a into master Oct 15, 2024
16 checks passed
@kabaros kabaros deleted the fix/sharing-dialog-type branch October 15, 2024 10:50
dhis2-bot added a commit that referenced this pull request Oct 15, 2024
## [9.11.8](v9.11.7...v9.11.8) (2024-10-15)

### Bug Fixes

* **sharing-dialog:** add 'route' to SharingType type ([#1617](#1617)) ([1d9664a](1d9664a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.11.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Nov 14, 2024
# [10.0.0-alpha.7](v10.0.0-alpha.6...v10.0.0-alpha.7) (2024-11-14)

### Bug Fixes

* **sharing-dialog:** add 'route' to SharingType type ([#1617](#1617)) ([1d9664a](1d9664a))
* revert "fix: select-field not showing in correct place" ([#1614](#1614)) ([c83de6b](c83de6b))
* **translations:** sync translations from transifex (master) ([491bf04](491bf04))
* update default props to JS default params ([#1598](#1598)) ([20e343f](20e343f))

### Features

* merge branch master into branch ([0577074](0577074))
* **icons:** add link-off icons ([e72be1e](e72be1e))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants