Skip to content

Commit

Permalink
fix(core): fix circular dependencies (#411)
Browse files Browse the repository at this point in the history
* chore(eslint): add import rules

* fix(select): fix circular dependency
  • Loading branch information
ismay authored Dec 15, 2020
1 parent b9b1872 commit 342f114
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,8 @@ module.exports = {
cy: 'readonly',
Cypress: 'readonly',
},
rules: {
'import/no-cycle': 'error',
'import/no-self-import': 'error',
},
}
4 changes: 3 additions & 1 deletion packages/core/src/Select/MenuWrapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ import { resolve } from 'styled-jsx/css'

import propTypes from '@dhis2/prop-types'

import { Card, Layer, Popper } from '../index.js'
import { Card } from '../Card/Card.js'
import { Layer } from '../Layer/Layer.js'
import { Popper } from '../Popper/Popper.js'

const MenuWrapper = ({
children,
Expand Down

0 comments on commit 342f114

Please sign in to comment.