Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analyticstablehooks): Slightly better UI and label language #2969

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

benguaraldi
Copy link
Contributor

@jimgrace had some suggestions for improvements to the UI of the analytics table hooks section of the Maintenance app, namely that the analytics and resource table dropdowns not appear until they are relevant and the phase dropdown be made more clear. This PR implements both.

Copy link
Member

@jimgrace jimgrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@benguaraldi
Copy link
Contributor Author

@Birkbjo, could you merge this PR? I don't seem to be authorized to.

@Birkbjo Birkbjo merged commit 05831ec into master Nov 4, 2024
6 checks passed
@Birkbjo Birkbjo deleted the DHIS2-13473/analytics-table-hooks-2 branch November 4, 2024 14:31
dhis2-bot added a commit that referenced this pull request Nov 4, 2024
## [32.32.3](v32.32.2...v32.32.3) (2024-11-04)

### Bug Fixes

* **analyticstablehooks:** Slightly better UI and label language ([#2969](#2969)) ([05831ec](05831ec))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 32.32.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@benguaraldi
Copy link
Contributor Author

Thank you, @Birkbjo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants